Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ASO to v2.11.0 #5428

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

bryan-cox
Copy link
Contributor

@bryan-cox bryan-cox commented Feb 12, 2025

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR bumps ASO from v2.9.0 to v2.11.0.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5275

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

Bumps ASO from v2.9.0 to v2.11.0

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 12, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 12, 2025
@bryan-cox bryan-cox changed the title Update aso dep Update ASO to v2.11.0 Feb 12, 2025
@willie-yao
Copy link
Contributor

/assign

@bryan-cox bryan-cox force-pushed the update-aso-dep branch 2 times, most recently from c536b8e to 68d4b41 Compare February 12, 2025 19:55
@bryan-cox bryan-cox marked this pull request as ready for review February 12, 2025 19:56
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.41%. Comparing base (202e091) to head (f5db230).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5428   +/-   ##
=======================================
  Coverage   52.41%   52.41%           
=======================================
  Files         272      272           
  Lines       29361    29361           
=======================================
  Hits        15390    15390           
  Misses      13165    13165           
  Partials      806      806           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2025
@mboersma
Copy link
Contributor

/cc @nojnhuh

@k8s-ci-robot k8s-ci-robot requested a review from nojnhuh February 13, 2025 14:08
@willie-yao
Copy link
Contributor

Is this ready for review? @bryan-cox

@bryan-cox
Copy link
Contributor Author

@willie-yao - yeah it is

Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @bryan-cox! Looks like there's currently a merge conflict.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2d52b6f37c8c1df35c0743f658ee13274363b5de

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 18, 2025
@willie-yao
Copy link
Contributor

Also, can you add a release note to the PR description?

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 18, 2025
@k8s-ci-robot k8s-ci-robot removed the release-note-none Denotes a PR that doesn't merit a release note. label Feb 18, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 18, 2025
@bryan-cox
Copy link
Contributor Author

@willie-yao - release note added and merge conflict resolved

@willie-yao
Copy link
Contributor

Ah crap sorry for the back and forth, can you also squash your commits?

This commit updates ASO to v2.11.0 so that CAPZ is using the latest
library version for this dependency.

Signed-off-by: Bryan Cox <[email protected]>
@bryan-cox
Copy link
Contributor Author

@willie-yao no worries, commits squashed

@willie-yao
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 162944683ca26bb1358c45061b3b93fce1aad6be

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: willie-yao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit eec0da9 into kubernetes-sigs:main Feb 18, 2025
22 checks passed
@bryan-cox bryan-cox deleted the update-aso-dep branch February 18, 2025 22:08
@rbjorklin
Copy link

Will this be backported to the release-1.18 branch or should I expect it to get released with v1.19.0?

@mboersma
Copy link
Contributor

@rbjorklin the project's support policy means that in general, only bug fixes and test improvements are cherry-picked. So this will probably wait until the v1.19.0 release, which is two weeks out.

cc: @nawazkh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Bump to ASO dep 2.11.0
5 participants