-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ASO to v2.11.0 #5428
Update ASO to v2.11.0 #5428
Conversation
Skipping CI for Draft Pull Request. |
/assign |
c536b8e
to
68d4b41
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5428 +/- ##
=======================================
Coverage 52.41% 52.41%
=======================================
Files 272 272
Lines 29361 29361
=======================================
Hits 15390 15390
Misses 13165 13165
Partials 806 806 ☔ View full report in Codecov by Sentry. |
68d4b41
to
8808349
Compare
/cc @nojnhuh |
Is this ready for review? @bryan-cox |
@willie-yao - yeah it is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @bryan-cox! Looks like there's currently a merge conflict.
LGTM label has been added. Git tree hash: 2d52b6f37c8c1df35c0743f658ee13274363b5de
|
Also, can you add a release note to the PR description? |
8808349
to
d05d0d3
Compare
@willie-yao - release note added and merge conflict resolved |
Ah crap sorry for the back and forth, can you also squash your commits? |
This commit updates ASO to v2.11.0 so that CAPZ is using the latest library version for this dependency. Signed-off-by: Bryan Cox <[email protected]>
d05d0d3
to
f5db230
Compare
@willie-yao no worries, commits squashed |
/lgtm |
LGTM label has been added. Git tree hash: 162944683ca26bb1358c45061b3b93fce1aad6be
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: willie-yao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Will this be backported to the |
@rbjorklin the project's support policy means that in general, only bug fixes and test improvements are cherry-picked. So this will probably wait until the v1.19.0 release, which is two weeks out. cc: @nawazkh |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR bumps ASO from v2.9.0 to v2.11.0.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #5275
Special notes for your reviewer:
TODOs:
Release note: