-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.17] fix ever-accumulating memory in logger #5286
[release-1.17] fix ever-accumulating memory in logger #5286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 02e704c8b7c10b296f551bdb2b29914336ed37f8
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind bug |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.17 #5286 +/- ##
================================================
- Coverage 52.88% 52.41% -0.47%
================================================
Files 273 273
Lines 29172 29176 +4
================================================
- Hits 15429 15294 -135
- Misses 12944 13084 +140
+ Partials 799 798 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
/retest |
2 similar comments
/retest |
/retest |
This is an automated cherry-pick of #5284
/assign nojnhuh