Default to Marketplace images for old Kubernetes versions

[mboersma]

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

Restores a truncated version of the Marketplace image lookup logic so that upgrading clusters don't see the change to community gallery images as a reason to recreate every Machine.

Which issue(s) this PR fixes:
Fixes #5229

Special notes for your reviewer:

• cherry-pick candidate

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

Default to Marketplace images for old Kubernetes versions

[mboersma]

/test pull-cluster-api-provider-azure-apiversion-upgrade

[mboersma]

/cc @willie-yao

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.82%. Comparing base (ec18b58) to head (5be6794).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5266      +/-   ##
==========================================
+ Coverage   52.78%   52.82%   +0.04%     
==========================================
  Files         270      270              
  Lines       29057    29085      +28     
==========================================
+ Hits        15337    15365      +28     
  Misses      12928    12928              
  Partials      792      792              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[willie-yao]

/test ?

[k8s-ci-robot]

@willie-yao: The following commands are available to trigger required jobs:

• /test pull-cluster-api-provider-azure-apiversion-upgrade
• /test pull-cluster-api-provider-azure-build
• /test pull-cluster-api-provider-azure-ci-entrypoint
• /test pull-cluster-api-provider-azure-e2e
• /test pull-cluster-api-provider-azure-e2e-aks
• /test pull-cluster-api-provider-azure-test
• /test pull-cluster-api-provider-azure-verify

The following commands are available to trigger optional jobs:

• /test pull-cluster-api-provider-azure-apidiff
• /test pull-cluster-api-provider-azure-capi-e2e
• /test pull-cluster-api-provider-azure-conformance
• /test pull-cluster-api-provider-azure-conformance-custom-builds
• /test pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts
• /test pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts
• /test pull-cluster-api-provider-azure-conformance-with-ci-artifacts
• /test pull-cluster-api-provider-azure-e2e-optional
• /test pull-cluster-api-provider-azure-e2e-workload-upgrade
• /test pull-cluster-api-provider-azure-load-test-custom-builds
• /test pull-cluster-api-provider-azure-windows-custom-builds
• /test pull-cluster-api-provider-azure-windows-with-ci-artifacts

Use /test all to run the following jobs that were automatically triggered:

• pull-cluster-api-provider-azure-apidiff
• pull-cluster-api-provider-azure-build
• pull-cluster-api-provider-azure-e2e
• pull-cluster-api-provider-azure-e2e-aks
• pull-cluster-api-provider-azure-test
• pull-cluster-api-provider-azure-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[willie-yao]

/lgtm

Gonna test this one more time and then approve!

/test pull-cluster-api-provider-azure-apiversion-upgrade

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: c875bdc26749ccc1d5daedcf5da64e7cadfb2239

[nojnhuh]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nojnhuh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment