Remove deprecated HPAContainerMetrics feature gate from templates

[nojnhuh]

What type of PR is this?
/kind failing-test

What this PR does / why we need it:

This PR fixes an error when running ci-version templates with bleeding-edge Kubernetes that includes this change to remove a feature gate that we reference in templates: kubernetes/kubernetes#126862

This is the error that pops up in the kube-controller-manager logs:

E1105 21:29:48.482259       1 run.go:72] "command failed" err="unrecognized feature gate: HPAContainerMetrics"

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

• cherry-pick candidate

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

NONE

[nojnhuh]

/cherry-pick release-1.16
/cherry-pick release-1.17

[k8s-infra-cherrypick-robot]

@nojnhuh: once the present PR merges, I will cherry-pick it on top of release-1.16, release-1.17 in new PRs and assign them to you.

In response to this:

/cherry-pick release-1.16
/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.77%. Comparing base (e2ad4e2) to head (fa612e8).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5242      +/-   ##
==========================================
- Coverage   52.78%   52.77%   -0.01%     
==========================================
  Files         270      270              
  Lines       29057    29057              
==========================================
- Hits        15337    15335       -2     
- Misses      12928    12930       +2     
  Partials      792      792              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jackfrancis]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 4cb2e9a98710c8d460925441882fdcc9c4d47795

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-infra-cherrypick-robot]

@nojnhuh: #5242 failed to apply on top of branch "release-1.16":

Applying: Remove deprecated HPAContainerMetrics feature gate from templates
Using index info to reconstruct a base tree...
A	templates/test/ci/cluster-template-prow-ci-version-dra.yaml
M	templates/test/ci/cluster-template-prow-ci-version-dual-stack.yaml
M	templates/test/ci/cluster-template-prow-ci-version-ipv6.yaml
M	templates/test/ci/cluster-template-prow-ci-version.yaml
A	templates/test/ci/patches/dra-kubeadmcontrolplane.yaml
A	templates/test/dev/cluster-template-custom-builds-dra.yaml
M	templates/test/dev/cluster-template-custom-builds.yaml
Falling back to patching base and 3-way merge...
Auto-merging templates/test/dev/cluster-template-custom-builds.yaml
Auto-merging templates/test/dev/cluster-template-custom-builds-machine-pool.yaml
CONFLICT (content): Merge conflict in templates/test/dev/cluster-template-custom-builds-machine-pool.yaml
CONFLICT (modify/delete): templates/test/ci/patches/dra-kubeadmcontrolplane.yaml deleted in HEAD and modified in Remove deprecated HPAContainerMetrics feature gate from templates. Version Remove deprecated HPAContainerMetrics feature gate from templates of templates/test/ci/patches/dra-kubeadmcontrolplane.yaml left in tree.
Removing templates/test/ci/patches/controller-manager-featuregates.yaml
Auto-merging templates/test/ci/cluster-template-prow-machine-pool-ci-version.yaml
CONFLICT (content): Merge conflict in templates/test/ci/cluster-template-prow-machine-pool-ci-version.yaml
Auto-merging templates/test/ci/cluster-template-prow-ci-version.yaml
Auto-merging templates/test/ci/cluster-template-prow-ci-version-ipv6.yaml
Auto-merging templates/test/ci/cluster-template-prow-ci-version-dual-stack.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Remove deprecated HPAContainerMetrics feature gate from templates

In response to this:

/cherry-pick release-1.16
/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@nojnhuh: new pull request created: #5243

In response to this:

/cherry-pick release-1.16
/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.