-
Notifications
You must be signed in to change notification settings - Fork 440
Fix aks-create when default az output isn't JSON #5191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aks-create when default az output isn't JSON #5191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 3c1f968d82391d9ac68f23317e25779619f0be5f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
54fdcb3
to
02ad1f4
Compare
Oops, sorry, I changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: c17bbb4269472ac8ed958540542e77fe4aca99fc
|
@mboersma: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5191 +/- ##
=======================================
Coverage 51.35% 51.35%
=======================================
Files 273 273
Lines 24670 24670
=======================================
Hits 12670 12670
Misses 11211 11211
Partials 789 789 ☔ View full report in Codecov by Sentry. |
/lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Adds
-o json
to twoaz
commands inaks-create
to ensure that the output is JSON and can be parsed. (Users can configure a different default output foraz
; mine is--output table
, which was causing thesejq
commands to fail.)Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
TODOs:
Release note: