Bump CAPI to v1.8.4

[mboersma]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates CAPI to v1.8.4.

Which issue(s) this PR fixes:

N/A, but see #5128 for prior art.

Special notes for your reviewer:

• cherry-pick candidate

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

Bump CAPI to v1.8.4

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.35%. Comparing base (adb583a) to head (bfc7bef).
Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5186   +/-   ##
=======================================
  Coverage   51.34%   51.35%           
=======================================
  Files         273      273           
  Lines       24670    24670           
=======================================
+ Hits        12668    12670    +2     
+ Misses      11213    11211    -2     
  Partials      789      789           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mboersma]

/cherrypick release-1.17

[k8s-infra-cherrypick-robot]

@mboersma: once the present PR merges, I will cherry-pick it on top of release-1.17 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jackfrancis]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: e20b5a1a72235fd001f1603e3c0f4037fa9c761b

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[willie-yao]

/retest

[k8s-infra-cherrypick-robot]

@mboersma: #5186 failed to apply on top of branch "release-1.17":

Applying: Bump CAPI to v1.8.4
Using index info to reconstruct a base tree...
M	Makefile
M	Tiltfile
M	go.mod
M	go.sum
M	test/e2e/config/azure-dev.yaml
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/config/azure-dev.yaml
CONFLICT (content): Merge conflict in test/e2e/config/azure-dev.yaml
Auto-merging go.sum
Auto-merging go.mod
Auto-merging Tiltfile
Auto-merging Makefile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Bump CAPI to v1.8.4

In response to this:

/cherrypick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.