Skip to content

Bump golangci-lint to v1.60.2 #5110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nawazkh opened this issue Sep 4, 2024 · 6 comments · Fixed by #5158
Closed

Bump golangci-lint to v1.60.2 #5110

nawazkh opened this issue Sep 4, 2024 · 6 comments · Fixed by #5158
Assignees
@nawazkh
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@nawazkh
Copy link
Member

nawazkh commented Sep 4, 2024

Taking inspiration from CAPI kubernetes-sigs/cluster-api#11075
Let's also bump CAPZ's golangci-lint to latest v1.60.2 release.

/help
@k8s-ci-robot
Copy link
Contributor

@nawazkh:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Taking inspiration from CAPI kubernetes-sigs/cluster-api#11075
Let's also bump CAPZ's golangci-lint to latest v1.60.2 release.

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 4, 2024
@mboersma mboersma added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Sep 5, 2024
@bryan-cox
Copy link
Contributor

I can take it 👍🏻
/assign

@bryan-cox bryan-cox mentioned this issue Sep 5, 2024
Closed
4 tasks
@nawazkh nawazkh mentioned this issue Sep 5, 2024
Closed
4 tasks
@bryan-cox
Copy link
Contributor

Hey @nawazkh 👋🏻 - I didn't realize you were planning to work this and assigned it to myself 😄

I'll remove myself and close the draft PR I had opened.

@bryan-cox
Copy link
Contributor

/unassign

@nawazkh

This comment was marked as outdated.

Sign in to view
@nawazkh
Copy link
Member Author

nawazkh commented Sep 5, 2024

Chatted with Bryan offline (sorry about the confusion!) I will try finishing this issue in this week.
/assign

@mboersma mboersma removed the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Sep 5, 2024
@nawazkh nawazkh mentioned this issue Oct 3, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nawazkh nawazkh

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
CAPZ Planning
Archived in project
Milestone
No milestone
4 participants
@mboersma @k8s-ci-robot @nawazkh @bryan-cox