Skip to content

🌱 Bump CAPI to v1.10.4 #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🌱 Bump CAPI to v1.10.4 #386

wants to merge 1 commit into from
+333 −363

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Apr 7, 2025 •
edited
Loading

What this PR does / why we need it:

Bumps the Cluster API dependency to release v1.10.4.

Which issue(s) this PR fixes:

Fixes #371

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 7, 2025
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Apr 7, 2025
@mboersma
Copy link
Contributor Author

mboersma commented Apr 7, 2025

/test pull-cluster-api-addon-provider-helm-test-main

@mboersma mboersma removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2025
@mboersma
Copy link
Contributor Author

mboersma commented Apr 7, 2025

/test pull-cluster-api-addon-provider-helm-verify-main
/test pull-cluster-api-addon-provider-helm-build-main
/test pull-cluster-api-addon-provider-helm-test-mink8s-main

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 7, 2025
@mboersma
Copy link
Contributor Author

mboersma commented Apr 7, 2025

/test pull-cluster-api-addon-provider-helm-verify-main

@mboersma
Copy link
Contributor Author

mboersma commented Apr 8, 2025

/test pull-cluster-api-addon-provider-helm-test-main
/test pull-cluster-api-addon-provider-helm-test-mink8s-main
/test pull-cluster-api-addon-provider-helm-build-main

@mboersma mboersma changed the title 🌱 Bump CAPI to v1.10.0-beta.1 🌱 Bump CAPI to v1.10.0-rc.1 Apr 21, 2025
@mboersma
Copy link
Contributor Author

/test pull-cluster-api-addon-provider-helm-verify-main
/test pull-cluster-api-addon-provider-helm-test-main
/test pull-cluster-api-addon-provider-helm-test-mink8s-main
/test pull-cluster-api-addon-provider-helm-build-main

@mboersma mboersma changed the title 🌱 Bump CAPI to v1.10.0-rc.1 🌱 Bump CAPI to v1.10.0 Apr 22, 2025
@mboersma mboersma marked this pull request as ready for review April 22, 2025 16:21
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2025
@mboersma mboersma force-pushed the capi-one-ten branch 3 times, most recently from 3a6c7ed to 73cba9b Compare April 25, 2025 17:10
dmvolod
dmvolod reviewed May 3, 2025
View reviewed changes
api/v1alpha1/helmchartproxy_webhook.go
@@ -37,19 +37,19 @@ var helmchartproxylog = logf.Log.WithName("helmchartproxy-resource")
func (r *HelmChartProxy) SetupWebhookWithManager(mgr ctrl.Manager) error {
return ctrl.NewWebhookManagedBy(mgr).
For(r).
WithDefaulter(r).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mboersma What do you think about moving web-hooks to the separate package and exclude it from the apidiff calculation to avoid confusion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea @dmvolod. I'll try to get back to this soon and figure out the CI failures, and I'll take a look at that refactoring.

@mboersma mboersma mentioned this pull request May 5, 2025
Closed
@Jont828
Copy link
Contributor

Jont828 commented May 6, 2025

Let me know if you need help debugging the e2e test failures!

@mboersma
Copy link
Contributor Author

/retitle 🌱 Bump CAPI to v1.10.1

@k8s-ci-robot k8s-ci-robot changed the title 🌱 Bump CAPI to v1.10.0 🌱 Bump CAPI to v1.10.1 May 12, 2025
@Jont828
Copy link
Contributor

Jont828 commented Jun 20, 2025

@mboersma Are you still working on this?

@mboersma mboersma changed the title 🌱 Bump CAPI to v1.10.1 🌱 Bump CAPI to v1.10.3 Jun 20, 2025
@mboersma mboersma moved this from Todo to Needs Review in CAPZ Planning Jun 20, 2025
This was referenced Jun 20, 2025
Closed
Merged
This was referenced Jun 20, 2025
Merged
Merged
@mboersma
Copy link
Contributor Author

@Jont828 thanks for the nudge, I updated this PR but there are still some failures. Let me know if you have any ideas. I think I've updated all the metadata files correctly but it seems like that kind of failure.

dmvolod
dmvolod reviewed Jun 20, 2025
View reviewed changes
@mboersma
Copy link
Contributor Author

/hold

I think #406 and #407 should merge first. I'll rebase this once they do.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2025
@mboersma mboersma force-pushed the capi-one-ten branch 2 times, most recently from 5dc2ee0 to b74581a Compare June 21, 2025 01:36
@mboersma mboersma mentioned this pull request Jun 23, 2025
Closed
@Jont828
Copy link
Contributor

Jont828 commented Jun 23, 2025

/retest

@mboersma mboersma moved this from Needs Review to In Progress in CAPZ Planning Jul 7, 2025
@hrak hrak mentioned this pull request Jul 10, 2025
Closed
@mboersma mboersma mentioned this pull request Jul 21, 2025
Closed
@mboersma mboersma changed the title 🌱 Bump CAPI to v1.10.3 🌱 Bump CAPI to v1.10.4 Jul 21, 2025
@k8s-ci-robot
Copy link
Contributor

@mboersma: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-addon-provider-helm-apidiff-main de03954 link false /test pull-cluster-api-addon-provider-helm-apidiff-main
pull-cluster-api-addon-provider-helm-e2e de03954 link true /test pull-cluster-api-addon-provider-helm-e2e
pull-cluster-api-addon-provider-helm-apiversion-upgrade de03954 link false /test pull-cluster-api-addon-provider-helm-apiversion-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmvolod dmvolod dmvolod left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@Jont828 Jont828 Awaiting requested review from Jont828

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
CAPZ Planning
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CAPI v1.10.0-beta.0 has been released and is ready for testing
4 participants
@mboersma @k8s-ci-robot @Jont828 @dmvolod