🐛 Fix e2e test by using quay.io for images

[jimmidyson]

Images are not automatically published to MCR on each Calico release to use quay.io instead, where Calico images are pushed as part of the Calico release process (see https://github.com/projectcalico/calico/blob/master/hack/release/pkg/builder/builder.go#L29-L37).

[jimmidyson]

/cc @mboersma

[jimmidyson]

/test pull-cluster-api-addon-provider-helm-e2e

[mboersma]

/lgtm
/assign @Jont828

Thanks @jimmidyson!

[jimmidyson]

@mboersma I made a change to actually pull images from quay.io instead of mcr.microsoft.com as Calico publishes images there on release - that means we don't need to specify the Calico version so won't need to keep updating manually in future.

[mboersma]

that means we don't need to specify the Calico version

That's great, but I'm confused: I don't see where we specify the Calico version currently or how this PR changes this. Just because new releases will show up right away at quay.io rather than eventually at mcr.microsoft.com/oss?

I think there's a slight advantage to using the existing source, because (since I work at Microsoft) I've seen that build pipeline and I know it includes a lot of code scanning, security checks, and is done in a trusted build environment. So I think these images are potentially "safer," but I may be wrong and I'm not opposed to quay.io.

@jackfrancis @Jont828 do you have an opinion on changing the source of the Calico images?

[jimmidyson]

@mboersma

I don't see where we specify the Calico version currently or how this PR changes this

Current main does not specify the Calico version. My original commit in this PR (5508caa) that you lgtmed did specify the version to use, but I changed that in the latest commit to use the official open source images pushed as part of the calico release to quay.io. That removed the need to specify the Calico version as the latest version is always available.

As for image scanning, etc as this is only used for e2e tests, not production deployments, I personally wouldn't worry about that so much, especially as the images are pushed as part of the official Calico project release pipelines, not replicated there by some other process.

[mboersma]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimmidyson, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment