✨ Add e2e test to install and validate a Helm chart on a workload cluster #171
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/assign @mboersma |
Jont828
force-pushed
the
helm-install-spec
branch
from
c3a9463 to
f91857a
Compare
test/e2e/helm_test.go
Outdated
| }) | ||
| }) | ||
|
|
||
| // TODO: try to update Helm values and expect revision |
There was a problem hiding this comment.
IMHO we should implement any // TODOs or remove them from code and put into a GitHub issue if they represent future work.
There was a problem hiding this comment.
I was initially planning on putting it in this PR, which is why it was a TODO. But since this PR is getting rather large, I'll leave it out and open a new issue.
Jont828
force-pushed
the
helm-install-spec
branch
from
f91857a to
d33d8d1
Compare
|
/hold Since I need to squash |
k8s-ci-robot
added
the
do-not-merge/hold
|
@mboersma Responded to comments and also added a bit more to clean up the workload cluster after the test. Once you LGTM I can squash. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jont828, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Jont828
force-pushed
the
helm-install-spec
branch
from
7c0af28 to
d00fcd9
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
What this PR does / why we need it: Adds a test spec to install any Helm chart on a workload cluster and make sure that it the HelmReleaseProxy ready condition is true and that the Helm release status is deployed.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #172