✨ feat(helm release): use custom creds for private OCI

[sebltm]

What this PR does / why we need it: Add the ability to use either static creds mounted in the Pod or available as a Secret to access private OCI repositories where Helm charts are stored

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #30

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: sebltm / name: Sébastien Michel (ea56f03)

[k8s-ci-robot]

Welcome @sebltm!

It looks like this is your first PR to kubernetes-sigs/cluster-api-addon-provider-helm 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-addon-provider-helm has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @sebltm. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yalctay93]

I'd like to say that this would be an awesome addition for our needs as well so kudos to you for doing this! I believe some sort of documentation for this feature would be nice, maybe here ?

[Jont828]

/ok-to-test

[Jont828]

Nice work on this so far! I just had a couple questions, and it looks like you need to fix some failing tests and verification as well.

[Jont828]

Seems like you need to fix the test in helmreleaseproxy_controller.go at line 265 due to the wrong number of arguments, and you might need to run go mod tidy as well.

[sebltm]

/retest

[Jont828]

Overall this is looking good! Just had a couple questions

[Jont828]

Nice work! Just a suggestion on how we could change the spec types a bit in HelmChartProxy (and HelmReleaseProxy).

[Jont828]

Just a couple nits. Once you get those and squash the branch, I think we'll be good to merge!

[Jont828]

LGTM, could you squash your commits so we can merge?

[Jont828]

@sebltm Looks like there's an issue with squashing -- I'm seeing two commits in the PR with the same description, might be a rebase error or something.

[Jont828]

Thanks for all your hard work on this feature!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jont828, sebltm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Jont828]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment