Skip to content

fix: add http timeout to avoid connection stuck #8383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

feiskyer
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

Follow-up of #8352, add http client timeout so that client won't need to wait 15 minutes of system default timeout.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: add http timeout to avoid connection stuck

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Feb 20, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from jwtty and nilo19 February 20, 2025 05:44
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 20, 2025
@MartinForReal
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2025
@feiskyer
Copy link
Member Author

/cherry-pick release-1.32

@k8s-infra-cherrypick-robot

@feiskyer: once the present PR merges, I will cherry-pick it on top of release-1.32 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@feiskyer
Copy link
Member Author

/cherry-pick release-1.31

@k8s-infra-cherrypick-robot

@feiskyer: once the present PR merges, I will cherry-pick it on top of release-1.31 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@feiskyer
Copy link
Member Author

/cherry-pick release-1.30

@k8s-infra-cherrypick-robot

@feiskyer: once the present PR merges, I will cherry-pick it on top of release-1.30 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@feiskyer
Copy link
Member Author

/cherry-pick release-1.29

@k8s-infra-cherrypick-robot

@feiskyer: once the present PR merges, I will cherry-pick it on top of release-1.29 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@feiskyer
Copy link
Member Author

/cherry-pick release-1.28

@k8s-infra-cherrypick-robot

@feiskyer: once the present PR merges, I will cherry-pick it on top of release-1.28 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@feiskyer
Copy link
Member Author

/retest

2 similar comments
@feiskyer
Copy link
Member Author

/retest

@feiskyer
Copy link
Member Author

/retest

@mainred
Copy link
Contributor

mainred commented Feb 21, 2025

/retest

@feiskyer
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit efd34de into kubernetes-sigs:master Feb 21, 2025
18 checks passed
@k8s-infra-cherrypick-robot

@feiskyer: #8383 failed to apply on top of branch "release-1.28":

Applying: fix: add http timeout to avoid connection stuck
Using index info to reconstruct a base tree...
M	pkg/azclient/factory_conf.go
M	pkg/azclient/utils/options.go
M	pkg/provider/azure_instance_metadata.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/provider/azure_instance_metadata.go
Auto-merging pkg/azclient/utils/options.go
CONFLICT (content): Merge conflict in pkg/azclient/utils/options.go
Auto-merging pkg/azclient/factory_conf.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 fix: add http timeout to avoid connection stuck

In response to this:

/cherry-pick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@feiskyer: new pull request created: #8396

In response to this:

/cherry-pick release-1.32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@feiskyer: new pull request created: #8397

In response to this:

/cherry-pick release-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@feiskyer: new pull request created: #8398

In response to this:

/cherry-pick release-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@feiskyer: new pull request created: #8399

In response to this:

/cherry-pick release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants