Bug fixes in go dependencies #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This commit modifies the go dependency tracker to avoid the generator exiting when a go package cannot be converted to a go dependency. This is the case with internal go packages that are not fetchable in a public repo. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This commit prevents the go module being scanned to be added as a dependency when building the go deps. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
k8s-ci-robot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: puerco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
thanks jeremy !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes three bugs in the go dependency code:
Which issue(s) this PR fixes:
Fixes #61
Special notes for your reviewer:
/assign @cpanato @justaugustus @saschagrunert
/cc @kubernetes-sigs/release-engineering
Does this PR introduce a user-facing change?