Skip to content

fix: check local image cache first #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2022
Merged

fix: check local image cache first #73

merged 1 commit into from
Mar 16, 2022

Conversation

developer-guy
Copy link
Contributor

@developer-guy developer-guy commented Mar 14, 2022 •
edited
Loading

Fixes #72

Signed-off-by: Batuhan Apaydın [email protected]

What type of PR is this?

/kind bug

What this PR does / why we need it:

It will check local image cache before trying to pull image from registry

Which issue(s) this PR fixes:

Fixes #72

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: check local image cache first

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 14, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @developer-guy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 14, 2022
@puerco
Copy link
Member

puerco commented Mar 15, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 15, 2022
@puerco
Copy link
Member

puerco commented Mar 15, 2022

@developer-guy in addition to the test please change the commit message dropping the "fixes #" (you can leave it in the PR).

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 15, 2022
@developer-guy developer-guy force-pushed the fix/72 branch 3 times, most recently from 3c3b926 to 94cb940 Compare March 15, 2022 20:16
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 15, 2022
@developer-guy developer-guy force-pushed the fix/72 branch 4 times, most recently from 6531c9b to 22543e3 Compare March 15, 2022 20:29
@developer-guy
fix: check local image cache first
1a875b7 
Signed-off-by: Batuhan Apaydın <[email protected]>
@developer-guy
Copy link
Contributor Author

@puerco I think somethings are wrong in Prow pull-bom-verify job, it says:

Init container clonerefs not ready: (state: waiting, reason: "PodInitializing", message: "") I

saschagrunert
saschagrunert approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 16, 2022
cpanato
cpanato approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, developer-guy, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@puerco
Copy link
Member

puerco commented Mar 16, 2022

/test pull-bom-test

@k8s-ci-robot k8s-ci-robot merged commit 8d8b533 into kubernetes-sigs:main Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@cpanato cpanato cpanato approved these changes

Assignees

@saschagrunert saschagrunert

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bom tries to pull down the image from a registry even if it exists in local image cache
5 participants
@developer-guy @k8s-ci-robot @puerco @saschagrunert @cpanato