Fix flake in TestToProvenance and TestWriteProvenance #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `TestToProvenance` test was flaking because the order of the provenance subjects was unpredicatable and require.Equal did not always match the SUT and the know example. This change modifies the check to compare the Subject hashes one by one and avoid the 1/3 chance that the test would flake. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
k8s-ci-robot
added
the
kind/failing-test
k8s-ci-robot
added
cncf-cla: yes
This commit adds two new function compareSubjects() and testStatement() to reuse the logic and fix a flake in TestWriteProvenance() Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
k8s-ci-robot
added
size/M
puerco
changed the title
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, puerco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
/kind flake
What this PR does / why we need it:
The
TestToProvenancetest was flaking because the order of the provenance subjects was unpredictable causingrequire.Equalto fail to match the SUT against the known example.The same flake was happening in
TestWriteProvenance. So a second commit introduces a function to compareprovenance Subjects that both tests share.
This change modifies the check to compare the Subject hashes one by one and avoid the 1/3 chance that the test would flake.
Signed-off-by: Adolfo García Veytia (Puerco) [email protected]
Which issue(s) this PR fixes:
Related to flakes in #24 and #18
Special notes for your reviewer:
Does this PR introduce a user-facing change?