Disable local cache lookup, favor parallel download #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Container image referencess are no longer resolved using the local daemon. This caused a bug where references pointing to indices were resolveds as single arch images. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Aparently, there is no way to access the local arch blobs behind a multiarch index using GGCR when they have been cached by pulling the index ref. Therefore, this commit completely removes the local daemon checks from the download code. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This commit parallelizes arch image downloads to download them 4 at a time. It also abstracts the image reference data into a type of its own to simplify the code and interfaces. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
k8s-ci-robot
added
kind/bug
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
saschagrunert
approved these changes
Jul 18, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: puerco, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR disables the local daemon lookup of container images to fix #134.
When passing a reference to a multiarch image to the local docker daemon, the reference gets transalated to the local arch image, generating an SBOM only for the image corresponding to the local architecture.
This PR reverts the local daemon change as apparently there is no way to get the docker daemon to return the correct reference (to the image index ) to GGCR.
In order to improve image download times the blob downloads to local tarballs are now parallelized which should at least provide some speed gains.
Which issue(s) this PR fixes:
Fixes #134
Special notes for your reviewer:
/cc @kubernetes-sigs/release-engineering
Does this PR introduce a user-facing change?