add initial filetype support #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Panato <[email protected]>
k8s-ci-robot
added
the
kind/feature
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
puerco
reviewed
Dec 22, 2021
| require.EqualValues(t, []string{"SOURCE"}, fileType) | ||
| require.NoError(t, os.RemoveAll(dir)) | ||
|
|
||
| file, dir, err = createTempFile("honk.*.mp3") |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, puerco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
puerco
added a commit
to puerco/bom
that referenced
this pull request
Feb 2, 2022
\ kubernetes-sigs#12 added support for adding filetypes to generated SBOMs, this commit comlpletes the parser side by supporting file types when parsing. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
puerco
added a commit
to puerco/bom
that referenced
this pull request
Feb 4, 2022
\ kubernetes-sigs#12 added support for adding filetypes to generated SBOMs, this commit comlpletes the parser side by supporting file types when parsing. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
https://spdx.github.io/spdx-spec/file-information/#83-file-type-field
/assign @puerco @justaugustus @saschagrunert
cc @kubernetes-sigs/release-engineering
Which issue(s) this PR fixes:
Fixes: #10
Special notes for your reviewer:
Does this PR introduce a user-facing change?