Skip to content

fix: respect ReadOnly AccessMode in volume mount #2031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: respect ReadOnly AccessMode in volume mount

When user sets ReadOnlyMany or ReadOnlyOnce on the volume accessmode, the driver should append "ro" mount option during mount

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

fix: respect ReadOnly AccessMode in volume mount

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 4, 2024
@k8s-ci-robot k8s-ci-robot requested review from cvvz and gnufied August 4, 2024 09:11
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 4, 2024
@andyzhangx andyzhangx force-pushed the set-readonly-from-accessmode branch from 9e27f40 to 5a6278c Compare August 4, 2024 09:26
@andyzhangx andyzhangx force-pushed the set-readonly-from-accessmode branch from 5a6278c to 8cf84e8 Compare August 4, 2024 15:50
@k8s-ci-robot
Copy link
Contributor

@andyzhangx: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azurefile-csi-driver-e2e-capz-windows-2019 8cf84e8 link true /test pull-azurefile-csi-driver-e2e-capz-windows-2019
pull-azurefile-csi-driver-e2e-capz-windows-2019-hostprocess 8cf84e8 link true /test pull-azurefile-csi-driver-e2e-capz-windows-2019-hostprocess
pull-azurefile-csi-driver-e2e-migration-windows 8cf84e8 link true /test pull-azurefile-csi-driver-e2e-migration-windows
pull-azurefile-csi-driver-e2e-capz-windows-2022-hostprocess 8cf84e8 link true /test pull-azurefile-csi-driver-e2e-capz-windows-2022-hostprocess

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx merged commit dc7f6ce into master Aug 5, 2024
25 of 30 checks passed
@andyzhangx
Copy link
Member Author

/cherrypick release-1.24

@andyzhangx
Copy link
Member Author

/cherrypick release-1.30

@k8s-infra-cherrypick-robot

@andyzhangx: #2031 failed to apply on top of branch "release-1.24":

Applying: fix: respect ReadOnly AccessMode in volume mount
Using index info to reconstruct a base tree...
M	pkg/azurefile/nodeserver.go
M	pkg/azurefile/utils.go
M	pkg/azurefile/utils_test.go
M	test/e2e/dynamic_provisioning_test.go
M	test/e2e/testsuites/specs.go
M	test/e2e/testsuites/testsuites.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/testsuites/testsuites.go
CONFLICT (content): Merge conflict in test/e2e/testsuites/testsuites.go
Auto-merging test/e2e/testsuites/specs.go
CONFLICT (content): Merge conflict in test/e2e/testsuites/specs.go
Auto-merging test/e2e/dynamic_provisioning_test.go
CONFLICT (content): Merge conflict in test/e2e/dynamic_provisioning_test.go
Auto-merging pkg/azurefile/utils_test.go
Auto-merging pkg/azurefile/utils.go
Auto-merging pkg/azurefile/nodeserver.go
CONFLICT (content): Merge conflict in pkg/azurefile/nodeserver.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: respect ReadOnly AccessMode in volume mount
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@andyzhangx: new pull request created: #2032

In response to this:

/cherrypick release-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants