Skip to content

Revert win http endpoint 1.29 #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 140 commits into from
Closed

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: revert http-endpoint change on windows daemonset

cherrypick of #1814

  • liveness-probe http-endpoint does not work on windows node, it failed with following error:
Events:
  Type     Reason     Age                   From     Message
  ----     ------     ----                  ----     -------
  Warning  BackOff    9m50s (x89 over 45m)  kubelet  Back-off restarting failed container azuredisk in pod csi-azuredisk-node-win-5lzvb_kube-system(b5c4b7b5-7205-4f7c-a665-413fe6db981f)
  Warning  Unhealthy  4m26s (x75 over 68m)  kubelet  Liveness probe failed: Get "http://localhost:29603/healthz": dial tcp [::1]:29603: connectex: No connection could be made because the target machine actively refused it.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

fix: revert http-endpoint change on windows daemonset

andyzhangx and others added 30 commits September 19, 2023 14:02
…1450-to-release-1.29

[release-1.29] test: not print controller metrics in logs due to IP retrieval issue
…1449-to-release-1.29

[release-1.29] chore: provide a driver flag to print volume stats call with log level 2
…1278-to-release-1.29

[release-1.29] feat: support volume cloning
…1468-to-release-1.29

[release-1.29] cleanup: remove ControllerPublishVolume capability
…trics-1.29

[release-1.29] fix: refine create volume metrics
…1481-to-release-1.29

[release-1.29] test: fix verify-helm-chart failure
…1391-to-release-1.29

[release-1.29] fix: check storage account type if parameter is missing
test: add flake-attempts in external e2e test

test: remove unsupported ginko parameters

fix
…1491-to-release-1.29

[release-1.29] test: enable cloudprovider_azure metrics print
…1505-to-release-1.29

[release-1.29] fix: nfs volume creation failure due to Microsoft.Storage.Global Service endpoint enabled
andyzhangx and others added 21 commits March 9, 2024 13:51
…1745-to-release-1.29

[release-1.29] fix: nfs protocol does not support standard account
…1750-to-release-1.29

[release-1.29] test: ignore azcopy CVE-2024-24786
…1.29

[release-1.29] feat: upgrade azcopy version to 10.23.0 for volume clone feature
…1777-to-release-1.29

[release-1.29] fix: strip service account token
…1783-to-release-1.29

[release-1.29] fix: workload identity did not work
Bumps build-image/debian-base from bookworm-v1.0.1 to bookworm-v1.0.2.
…1786-to-release-1.29

[release-1.29] build(deps): bump build-image/debian-base from bookworm-v1.0.1 to bookworm-v1.0.2 in /pkg/azurefileplugin
…1795-to-release-1.29

[release-1.29] fix: panic when cloud config is not set
[release-1.29] feat: use new restricted liveness probe endpoint
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 9, 2024
@andyzhangx andyzhangx closed this Apr 9, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2024
@k8s-ci-robot
Copy link
Contributor

@andyzhangx: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azurefile-csi-driver-windows-build 9a3c9af link true /test pull-azurefile-csi-driver-windows-build
pull-azurefile-csi-driver-unit 9a3c9af link true /test pull-azurefile-csi-driver-unit
pull-azurefile-csi-driver-verify 9a3c9af link true /test pull-azurefile-csi-driver-verify
pull-azurefile-csi-driver-e2e-migration 9a3c9af link true /test pull-azurefile-csi-driver-e2e-migration
pull-azurefile-csi-driver-external-e2e-smb 9a3c9af link true /test pull-azurefile-csi-driver-external-e2e-smb
pull-azurefile-csi-driver-e2e-migration-windows 9a3c9af link true /test pull-azurefile-csi-driver-e2e-migration-windows
pull-azurefile-csi-driver-sanity 9a3c9af link true /test pull-azurefile-csi-driver-sanity
pull-azurefile-csi-driver-e2e-capz 9a3c9af link true /test pull-azurefile-csi-driver-e2e-capz
pull-azurefile-csi-driver-e2e-capz-windows-2019-hostprocess 9a3c9af link true /test pull-azurefile-csi-driver-e2e-capz-windows-2019-hostprocess
pull-azurefile-csi-driver-e2e-capz-windows-2019 9a3c9af link true /test pull-azurefile-csi-driver-e2e-capz-windows-2019
pull-azurefile-csi-driver-e2e-capz-windows-2022-hostprocess 9a3c9af link true /test pull-azurefile-csi-driver-e2e-capz-windows-2022-hostprocess
pull-azurefile-csi-driver-external-e2e-nfs 9a3c9af link true /test pull-azurefile-csi-driver-external-e2e-nfs

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andyzhangx andyzhangx deleted the revert-win-http-endpoint-1.29 branch April 12, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants