Skip to content

ossfs2: set default logdir to /dev/stdout #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025

Conversation

AlbeeSo
Copy link
Member

@AlbeeSo AlbeeSo commented May 6, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

use /dev/stdout as default log_dir for ossfs 2.0.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 6, 2025
@k8s-ci-robot k8s-ci-robot requested review from huww98 and tydra-wang May 6, 2025 03:29
Comment on lines 179 to 183
parts := strings.SplitN(option, "=", 2)
if len(parts) == 1 {
parts = append(parts, "")
}
tm[parts[0]] = parts[1]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
parts := strings.SplitN(option, "=", 2)
if len(parts) == 1 {
parts = append(parts, "")
}
tm[parts[0]] = parts[1]
k, v, _ := strings.Cut(option, "=")
tm[k] = v

But I think we should have a unified place to do the parsing. Maybe AddDefaultMountOptions can just return all the defaults, and have another func DeduplicateOptions to parse the options and remove duplications? Mount options supports escaping with \ actually. It is complicated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if another func is needed to split the defaultMountOptions retrieving and duplications removing. It together works as AddDefaultMountOptions and it's meaningful. Maybe we can consider it if more default options need to be handled.

Copy link
Contributor

@mowangdk mowangdk Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to list the default options in comments and docs

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 7, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 2, 2025
@AlbeeSo AlbeeSo force-pushed the feat/save-logdir branch from 8891635 to ba57b18 Compare June 4, 2025 03:36
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 4, 2025
@mowangdk
Copy link
Contributor

/lgtm
/approve

@AlbeeSo TODO: Add default oss parameters to docs

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlbeeSo, mowangdk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit efeb836 into kubernetes-sigs:master Jun 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants