-
Notifications
You must be signed in to change notification settings - Fork 247
ossfs2: set default logdir to /dev/stdout #1394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ossfs2: set default logdir to /dev/stdout #1394
Conversation
pkg/mounter/oss/ossfs2.go
Outdated
parts := strings.SplitN(option, "=", 2) | ||
if len(parts) == 1 { | ||
parts = append(parts, "") | ||
} | ||
tm[parts[0]] = parts[1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parts := strings.SplitN(option, "=", 2) | |
if len(parts) == 1 { | |
parts = append(parts, "") | |
} | |
tm[parts[0]] = parts[1] | |
k, v, _ := strings.Cut(option, "=") | |
tm[k] = v |
But I think we should have a unified place to do the parsing. Maybe AddDefaultMountOptions
can just return all the defaults, and have another func DeduplicateOptions
to parse the options and remove duplications? Mount options supports escaping with \
actually. It is complicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if another func is needed to split the defaultMountOptions retrieving and duplications removing. It together works as AddDefaultMountOptions
and it's meaningful. Maybe we can consider it if more default options need to be handled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to list the default options in comments and docs
/lgtm @AlbeeSo TODO: Add default oss parameters to docs |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlbeeSo, mowangdk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
use /dev/stdout as default log_dir for ossfs 2.0.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: