Skip to content
This repository was archived by the owner on May 6, 2022. It is now read-only.

Add a hack for allowing us to talk to brokers that do not have proper… #605

Merged
merged 1 commit into from
Mar 23, 2017

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Mar 22, 2017

… certs for demo purposes

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 22, 2017
@pmorie pmorie added the LGTM1 label Mar 22, 2017
@pmorie
Copy link
Contributor

pmorie commented Mar 22, 2017

I need this hack personally to unblock some demo work for kubecon.

Copy link
Contributor

@MHBauer MHBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine for now. if it takes to long to add an --insecure flag or some such, I want an issue filed and linked.

@arschles
Copy link
Contributor

LGTM, I'd like the issue filed in addition to @MHBauer

@arschles arschles added the LGTM2 label Mar 22, 2017
@pmorie
Copy link
Contributor

pmorie commented Mar 22, 2017

@MHBauer

fine for now. if it takes to long to add an --insecure flag or some such, I want an issue filed and linked.

Please do

@pmorie
Copy link
Contributor

pmorie commented Mar 22, 2017

Related: #606

@vaikas
Copy link
Contributor Author

vaikas commented Mar 22, 2017

I'll add the --insecure flag as a follow on if that's ok...

@pmorie
Copy link
Contributor

pmorie commented Mar 23, 2017

Pulling this and testing now

@pmorie
Copy link
Contributor

pmorie commented Mar 23, 2017

Confirmed that:

  1. A broker with an incorrectly signed cert does not work without this patch
  2. A broker with an incorrectly signed cert does work with this patch

@pmorie pmorie merged commit edfa5a1 into kubernetes-retired:master Mar 23, 2017
@pmorie
Copy link
Contributor

pmorie commented Mar 23, 2017

Merging because I need this stat to unblock some time-sensitive work

@vaikas vaikas deleted the broker_no_cert_check branch March 24, 2017 19:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. LGTM1 LGTM2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants