This repository was archived by the owner on Apr 25, 2023. It is now read-only.
Handle possible conflict in updating test labels on cluster #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
irfanurrehman
force-pushed
the
test-flake-fix
branch
from
76ffa4b to
6f8021c
Compare
irfanurrehman
force-pushed
the
test-flake-fix
branch
from
6f8021c to
70191ee
Compare
irfanurrehman
force-pushed
the
test-flake-fix
branch
from
70191ee to
f3fe78c
Compare
|
@hectorj2f there was an update needed. Need LGTM label again. Thanks. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hectorj2f, irfanurrehman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The test on
masterafter the last PR push seems to be failing because of a test flake. This PR fixes thatRef: https://github.com/kubernetes-sigs/kubefed/runs/5593998914?check_suite_focus=true
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Test fix
Special notes for your reviewer: