Make kubefed webhook replica count configurable for High Availability…

[nitinatgh]

… (HA) and made default as 2 replicas

Added in description to the README.md
Bumped up the chart version of the controller manager
Bumped up the dependency version

What this PR does / why we need it: This PR gives the users an option to set the number of replicas for the Kubefed Admission Webhook

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1456

Special notes for your reviewer:
Tested it out as follows in a local kind cluster

$ kubectl get pods -A
NAMESPACE                NAME                                             READY   STATUS    RESTARTS   AGE
...
kube-federation-system   kubefed-admission-webhook-67fb48d5f7-kw4ps       1/1     Running   0          4d17h
...

helm upgrade dry-run

$ helm --namespace kube-federation-system upgrade -i kubefed ./kubefed --create-namespace --dry-run
...
# Source: kubefed/charts/controllermanager/templates/deployments.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  namespace: kube-federation-system
  name: kubefed-admission-webhook
  labels:
    kubefed-admission-webhook: "true"
spec:
  replicas: 2
  selector:
    matchLabels:
...

helm upgrade

$ helm --namespace kube-federation-system upgrade -i kubefed ./kubefed --create-namespace
Release "kubefed" has been upgraded. Happy Helming!
NAME: kubefed
LAST DEPLOYED: Tue Sep 14 10:33:35 2021
NAMESPACE: kube-federation-system
STATUS: deployed
REVISION: 13
TEST SUITE: None

$ kubectl get pods -A
NAMESPACE                NAME                                             READY   STATUS    RESTARTS   AGE
...
kube-federation-system   kubefed-admission-webhook-67fb48d5f7-kw4ps       1/1     Running   0          4d17h
kube-federation-system   kubefed-admission-webhook-67fb48d5f7-r4vf5       1/1     Running   0          93s
...

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nitinatgh
To complete the pull request process, please assign jimmidyson after the PR has been reviewed.
You can assign the PR to them by writing /assign @jimmidyson in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nitinatgh]

Hi @yuswift @makkes @xunpan ,

Is there any chance that someone can look at this before it goes stale?

Thanks

Nitin

[swiftslee]

Hi @yuswift @makkes @xunpan ,

Is there any chance that someone can look at this before it goes stale?

Thanks

Nitin

Thanks for your contribution!
/lgtm

[k8s-ci-robot]

@yuswift: changing LGTM is restricted to collaborators

In response to this:

Hi @yuswift @makkes @xunpan ,

Is there any chance that someone can look at this before it goes stale?

Thanks

Nitin

Thanks for your contribution!
/remove-lifecycle stale
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[swiftslee]

Unfortunately, I'm not the reviewer of kubefed, but the change looks good to me.

[nitinatgh]

Unfortunately, I'm not the reviewer of kubefed, but the change looks good to me.

Ok not a problem, thanks though.

Guess i'll have to wait then.

Nitin

[makkes]

LGTM provided @hectorj2f's comments are addressed. Thanka for this improvement

[makkes]

/lgtm

[xunpan]

as comments in #1453 (comment)

I think after merging #1453, this should be fine.

[nitinatgh]

Closing this as the branch doesn't exist and is now replaced by #1469
Sorry