Skip to content
This repository was archived by the owner on Apr 25, 2023. It is now read-only.

bump webhook version to v1 #1446

Closed

Conversation

swiftslee
Copy link
Contributor

@swiftslee swiftslee commented Aug 18, 2021

Signed-off-by: yuswift [email protected]

What this PR does / why we need it:
To support v1.22, we need to bump webhook version to v1.
ref #1445
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yuswift
To complete the pull request process, please assign xunpan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xunpan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from makkes and xunpan August 18, 2021 02:25
@swiftslee
Copy link
Contributor Author

/close
#1427 has fixed it

@k8s-ci-robot
Copy link
Contributor

@yuswift: Closed this PR.

In response to this:

/close
#1427 has fixed it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@swiftslee swiftslee deleted the upgrade-webhook branch August 18, 2021 02:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants