Skip to content
This repository was archived by the owner on Apr 25, 2023. It is now read-only.

chore: Add quickstart guide #1280

Merged
merged 3 commits into from
Sep 25, 2020

Conversation

makkes
Copy link
Contributor

@makkes makkes commented Sep 21, 2020

What this PR does / why we need it:
As a newbie to kubefed, it's not easy to start playing around with
kubefed due to the plethora of options on how to deploy it in the user
and development guides. Thus, an opinionated quickstart guide will
help newcomers get up and running in a jiffy.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
no issue

Special notes for your reviewer:

As a newbie to kubefed, it's not easy to start playing around with
kubefed due to the plethora of options on how to deploy it in the user
and development guides. Thus, an opinionated quickstart guide will
help newcomers get up and running in a jiffy.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 21, 2020
@makkes
Copy link
Contributor Author

makkes commented Sep 21, 2020

/assign @xunpan

Copy link
Contributor

@xunpan xunpan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is glad to see this quickstart to me. It is now clear to have a quick try to kubefed.

@makkes makkes requested a review from xunpan September 21, 2020 09:11
@xunpan
Copy link
Contributor

xunpan commented Sep 23, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2020
@makkes
Copy link
Contributor Author

makkes commented Sep 23, 2020

@hectorj2f I addressed your comments.

@xunpan would you mind lgtm'ing/approving again, please?

@xunpan
Copy link
Contributor

xunpan commented Sep 25, 2020

/lgtm

Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2020
@gyliu513
Copy link
Contributor

/approve

@hectorj2f
Copy link
Contributor

/lgtm

@hectorj2f
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gyliu513, hectorj2f, makkes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit ae7f9eb into kubernetes-retired:master Sep 25, 2020
@makkes makkes deleted the add-quickstart branch September 25, 2020 08:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants