Skip to content
This repository was archived by the owner on Sep 30, 2020. It is now read-only.

[v0.16.0] Switch CoreOS to Flatcar #1863

Merged
merged 1 commit into from
May 28, 2020
Merged

Conversation

dominicgunn
Copy link
Contributor

Changes

  • Switches to use Flatcar in the v0.16.x branch, shamelessly stolen from @jorge07, thanks!

@dominicgunn dominicgunn added this to the v0.16.0 milestone May 27, 2020
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dominicgunn
You can assign the PR to them by writing /assign @dominicgunn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from redbaron May 27, 2020 15:19
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 27, 2020
@jorge07
Copy link
Contributor

jorge07 commented May 27, 2020

pre-stolen from @davidmccormick 😂

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2020

Codecov Report

Merging #1863 into v0.16.x will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           v0.16.x    #1863      +/-   ##
===========================================
- Coverage    24.42%   24.41%   -0.01%     
===========================================
  Files           98       98              
  Lines         5114     5116       +2     
===========================================
  Hits          1249     1249              
- Misses        3725     3727       +2     
  Partials       140      140              
Impacted Files Coverage Δ
flatcar/amiregistry/amiregistry.go 0.00% <0.00%> (ø)
flatcar/amiregistry/reliable_http.go 86.36% <ø> (ø)
pkg/model/compiler.go 55.69% <ø> (ø)
pkg/model/node_pool_compile.go 60.25% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ed6a7...021d72f. Read the comment docs.

@dominicgunn dominicgunn merged commit a43cd06 into v0.16.x May 28, 2020
@mumoshu mumoshu deleted the feature/v0.16.x-flatcar branch May 28, 2020 11:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants