Skip to content
This repository was archived by the owner on Sep 30, 2020. It is now read-only.

Add proper indentation to extra CoreDNS config #1814

Merged
merged 1 commit into from
Jan 4, 2020

Conversation

javipolo
Copy link
Contributor

@javipolo javipolo commented Jan 3, 2020

When using more than one line of extra config, the indentation was not right and generated YAML was not valid

This should fix this issue also for 0.12.x (we're currently migrating away from it, but it feels right to leave a working version in the repo)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign redbaron
You can assign the PR to them by writing /assign @redbaron in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 3, 2020
@codecov-io
Copy link

codecov-io commented Jan 3, 2020

Codecov Report

Merging #1814 into v0.12.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           v0.12.x    #1814   +/-   ##
========================================
  Coverage    38.19%   38.19%           
========================================
  Files           75       75           
  Lines         4658     4658           
========================================
  Hits          1779     1779           
  Misses        2633     2633           
  Partials       246      246

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2b2335...4ee0ea1. Read the comment docs.

@davidmccormick davidmccormick added this to the v0.12.7 milestone Jan 4, 2020
@davidmccormick davidmccormick merged commit 0ea4367 into kubernetes-retired:v0.12.x Jan 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants