Skip to content
This repository was archived by the owner on Apr 17, 2025. It is now read-only.

Cherry pick of #289 #297

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Cherry pick of #289 #297

merged 1 commit into from
Jun 12, 2023

Conversation

zfrhv
Copy link
Contributor

@zfrhv zfrhv commented Jun 11, 2023

Cherry pick of #289 on master

#289: Add HRQ documentation

@zfrhv
Add HRQ documentation
6b0ac44 
Signed-off-by: unknown <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 11, 2023
@k8s-ci-robot k8s-ci-robot requested review from rjbez17 and tashimi June 11, 2023 18:16
@k8s-ci-robot
Copy link
Contributor

Hi @zfrhv. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 11, 2023
adrianludwin
adrianludwin reviewed Jun 12, 2023
View reviewed changes
Copy link
Contributor

@adrianludwin adrianludwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 12, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianludwin, zfrhv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0fc9d45 into kubernetes-retired:v1.1 Jun 12, 2023
@adrianludwin adrianludwin added this to the release-v1.1 milestone Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adrianludwin adrianludwin adrianludwin left review comments

@rjbez17 rjbez17 Awaiting requested review from rjbez17

@tashimi tashimi Awaiting requested review from tashimi

Assignees

@adrianludwin adrianludwin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
release-v1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@zfrhv @k8s-ci-robot @adrianludwin