Skip to content
This repository was archived by the owner on Mar 13, 2022. It is now read-only.
This repository was archived by the owner on Mar 13, 2022. It is now read-only.

supporting proxy authentication for websocket client(stream/ws_client.py) #255

Closed
@itaru2622

Description

@itaru2622

related to ansible-collections/kubernetes.core#246,
current kubernets-client/python-base and kubernetes-client/python support proxy authentication just for REST but NOT websocket.

This issue is caused by below line in python-base. It has no 'http_proxy_auth=xxx' .

websocket.connect(url, header=header, http_proxy_host=proxy_url.hostname, http_proxy_port=proxy_url.port)

In REST case, kubernets-client/python cares proxy authentication by 'proxy_headers' in following code:

https://github.com/kubernetes-client/python/blob/96dade6021dc2e9ee1430172e1b65d9e9e232b10/kubernetes/client/rest.py#L86-L97

where, configuration.proxy_headers are set by caller, like below code:

https://github.com/ansible-collections/kubernetes.core/blob/c65512357dd90b477dec683999128e0308a96f88/plugins/module_utils/common.py#L202-L204
and
https://github.com/ansible-collections/kubernetes.core/blob/c65512357dd90b477dec683999128e0308a96f88/plugins/module_utils/common.py#L139

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions