Skip to content

Add Deployment rollout restart example #2116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2022
Merged

Add Deployment rollout restart example #2116

merged 1 commit into from
Jan 31, 2022

Conversation

ddubson
Copy link
Contributor

@ddubson ddubson commented Jan 28, 2022 •
edited
Loading

This is a client-java v15.x compatible example of a Deployment resource rollout restart function which involves several indirect/non-trivial steps, which I thought could be quite useful for anyone seeking to have greater programmatic control over their Kubernetes deployments.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 28, 2022 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 28, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @ddubson!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 28, 2022
@ddubson
Copy link
Contributor Author

ddubson commented Jan 28, 2022 •
edited
Loading

/assign @yue9944882

brendandburns
brendandburns reviewed Jan 28, 2022
View reviewed changes
...ples-release-15/src/main/java/io/kubernetes/client/examples/DeployRolloutRestartExample.java Outdated
AppsV1Api appsV1Api = new AppsV1Api(client);

String deploymentName = "example-nginx";
String imageName = "nginx:latest";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, using the latest tag is an anti-pattern maybe make this a specific semantic version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 Thanks for catching that! I applied a specific tag 1.21.6 instead of latest.

@brendandburns
Copy link
Contributor

Thanks for the PR! One minor nit, otherwise LGTM.

yue9944882
yue9944882 reviewed Jan 29, 2022
View reviewed changes
Copy link
Member

@yue9944882 yue9944882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz run the formatter mvn spotless:apply, otherwise LGTM

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 29, 2022
@ddubson
Copy link
Contributor Author

ddubson commented Jan 29, 2022

@yue9944882 ah I was looking for the style formatter, thanks for guiding me to it. I applied it and re-pushed my changes.

@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, ddubson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 31, 2022
@k8s-ci-robot k8s-ci-robot merged commit a98b888 into kubernetes-client:master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns brendandburns left review comments

@yue9944882 yue9944882 yue9944882 left review comments

Assignees

@brendandburns brendandburns

@yue9944882 yue9944882

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ddubson @k8s-ci-robot @brendandburns @yue9944882