Skip to content

Fixes duplicated SharedProcessor#shouldResync calls #1727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2021
Merged

Fixes duplicated SharedProcessor#shouldResync calls #1727

merged 1 commit into from
May 26, 2021

Conversation

yue9944882
Copy link
Member

Fixes: #1721
@ydmao

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 24, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 24, 2021
yue9944882 referenced this pull request May 24, 2021
@wind57
clean-up, fix a bug, tests
e63a256
@ydmao
Copy link

ydmao commented May 24, 2021

this is great - thank you! When will we have the next release with this fix in?

codeyq
codeyq reviewed May 24, 2021
View reviewed changes
Copy link

@codeyq codeyq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick turnaround. Could this PR be back-ported to the 12.0.0 release branch?

@brendandburns
Copy link
Contributor

looks good, but adding a unit test makes sense.

@yue9944882 yue9944882 force-pushed the bugfix/duplicate-resync branch from f77ac6c to 399dea2 Compare May 25, 2021 07:13
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 25, 2021
@yue9944882 yue9944882 force-pushed the bugfix/duplicate-resync branch from 399dea2 to bd72515 Compare May 25, 2021 07:18
@yue9944882 yue9944882 mentioned this pull request May 25, 2021
Merged
@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,yue9944882]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2b062eb into kubernetes-client:master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeyq codeyq codeyq left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@brendandburns brendandburns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Periodic resync is not working
5 participants
@yue9944882 @ydmao @brendandburns @k8s-ci-robot @codeyq