Fix SpringExampleController so it doesn't crash on startup #1686
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
I understand the problem. It was actually introduced in ce7bc1b when we fixed the post processor. The old version used to instantiate beans (very bad) but then it had the concrete runtime type to inspect. The new version only has the declared bean type, which in these samples is /assign @brendandburns |
|
/assign @brendandburns |
There was a problem hiding this comment.
LGTM, @dsyer can you rebase onto the latest master so we can have a cleaner tree structure (b/c github does non-ff merge by default)
This fix is masking another problem somewhere else, but at least it gets the apps working while we investigate. Signed-off-by: Dave Syer <[email protected]>
|
Github can do "rebase on merge". Anyway I rebased manually and pushed it back. |
There was a problem hiding this comment.
Github can do "rebase on merge". Anyway I rebased manually and pushed it back.
thanks @dsyer, we're merging via the bot which i'm not sure capable of doing that
/lgtm
/approve
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsyer, yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This fix is masking another problem somewhere else, but at least it gets
the apps working while we investigate.
Fixes #1684 (temporarily at least). Also rebased on #1685.