Client overwriting my app's logback configuration

[taylorKonigsmark]

Hello everyone!

When adding the client as a dependency to my spring boot 2 application, the library is overwriting the logback configurations that I specified at /src/main/resources/logback-spring.xml.

my dependency config with gradle looks like:

compile('org.springframework.boot:spring-boot-starter-web')
compile('org.springframework.boot:spring-boot-starter-actuator')
compile('org.springframework.cloud:spring-cloud-starter-consul-config')

compile('org.elasticsearch.client:elasticsearch-rest-high-level-client:6.2.4')
compile('org.elasticsearch.client:transport:6.2.4')
compile ('io.reactivex.rxjava2:rxjava:2.1.13')
compile ('io.kubernetes:client-java:1.0.0')
compileOnly('org.springframework.boot:spring-boot-configuration-processor')
compileOnly('org.projectlombok:lombok')
testCompile('org.springframework.boot:spring-boot-starter-test')

my logback-spring.xml looks like this:

<configuration>
    <springProperty name="APP_VERSION" source="spring.application.version"/>
    <springProperty name="APP_NAME" source="spring.application.name"/>
    <appender name="consoleAppenderJson" class="ch.qos.logback.core.ConsoleAppender">
        <encoder class="net.logstash.logback.encoder.LoggingEventCompositeJsonEncoder">
            <providers>
                <mdc/><!-- MDC variables on the Thread will be written as JSON fields -->
                <context/> <!-- Outputs entries from logback's context -->
                <logLevel/>
                <loggerName/>
                <pattern>
                    <pattern>
                        {
                        "appName": "${APP_NAME}",
                        "appVersion": "${APP_VERSION}"
                        }
                    </pattern>
                </pattern>
                <threadName/>
                <message/>
                <logstashMarkers/> <!-- Useful so we can add extra information for specific log lines as Markers -->
                <arguments/> <!-- or through StructuredArguments -->
                <stackTrace/>
            </providers>
        </encoder>
    </appender>
    <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
        <encoder>
            <pattern>%date{yyyy-MM-dd HH:mm:ss.SSS} %-4relative [%thread] %-5level %marker %logger{35} - %msg %n
            </pattern>
        </encoder>
    </appender>
    <springProfile name="default,dev,ci,perf,stg,uat,prod">
        <root>
            <appender-ref ref="consoleAppenderJson"/>
        </root>
    </springProfile>
    <springProfile name="local">
        <root>
            <level value="INFO"/>
            <appender-ref ref="STDOUT"/>
        </root>
    </springProfile>
</configuration>

I couldn't find any documentation on this, so I imagine that this shouldn't be happening.

[brendandburns]

I can't imagine any reason why this would happen, unless somehow we're linking a spring-boot library accidentally? But I don't think so. I don't see any relevant libraries in a quick survey of our pom.xml files...

[taylorKonigsmark]

Thanks for the reply!

There is one other dependency that isn't in this picture, it's a internal library used by the company I'm working for. I figured it's not part of the issue as I would think these two dependencies wouldn't be conflicting with each other.

Here are the dependencies of that internal library for more visibility:

While this internal library does have spring boot packages in there. I excluded them in gradle resulting in this:

And the story is still the same, this dependency overwrites my logback-spring configuration.

[brendandburns]

Is there an easy way for me to try to reproduce this? I don't really do much with Spring...

Thanks

[taylorKonigsmark]

Going to close the ticket. Tried to replicate it and couldn't, it's probably something else clashing with the dependencies of this library.

Sorry about the confusion!

[taylorKonigsmark]

Actually, I was wrong! The demo does show this:

https://github.com/taylorKonigsmark/demo

To reproduce:

• ./gradlew clean build
• ./gradlew bootRun
• observe logs are made in json format
• go to gradle file and uncomment kubernetes dependency
• ./gradlew clean build
• ./gradlew bootRun
• observe logs are now in a stdout format

[remmeier]

I get:

 [jar:file:/C:/Users/Remo/.gradle/caches/modules-2/files-2.1/io.kubernetes/client-java/1.0.0/4bf42473e37aab25ec95ba6095dd26ea6a132c01/client-java-1.0.0.jar!/logback.xml]

and when looking at pom.xml in META-INF/maven/io.kubernetes/client-java I see:

    <dependency>
            <groupId>ch.qos.logback</groupId>
            <artifactId>logback-classic</artifactId>
            <version>1.2.3</version>
     </dependency>

both should go away, it is not the responsiblity of a library to provide the logging setup and a bit cumbersome to get rid of again in the application.

[remmeier]

something like the attached commit should do, can check later if it works properly

[brendandburns]

Fixed by #284