ci: ignore cni-server restarts caused by join network check failure

[zhangzujian]

Pull Request

• Make sure you have followed Kube-OVN Code Style.

What type of this PR

Examples of user facing changes:

• Features
• Bug fixes
• Docs
• Tests

Which issue(s) this PR fixes

Fixes #(issue-number)

[gemini-code-assist]

Hello @zhangzujian, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request modifies the ci-check-crash.sh script to improve the detection of crashed pods in the kube-system namespace. It now iterates through both init containers and regular containers to check their restart counts. Additionally, it adds a check to ignore cni-server restarts on Talos nodes if the logs indicate a "network not ready" error. This prevents false positives in CI when the network is temporarily unavailable during node joining.

Highlights

• Container Restart Checks: The script now checks restart counts for both init containers and regular containers within pods.
• Talos CNI Server Exception: The script ignores cni-server restarts on Talos nodes if the logs contain "network not ready", preventing false positives.
• Provider Detection: The script now detects if the node provider is Talos and adjusts the crash check accordingly.

Changelog

• hack/ci-check-crash.sh
  • Added provider detection to identify Talos nodes (lines 7-12).
  • Iterates through both init containers and regular containers to check restart counts (lines 17-36).
  • Added logic to ignore cni-server restarts on Talos nodes if the logs indicate a "network not ready" error (lines 29-32).
  • Uses set -e to exit immediately if a command exits with a non-zero status (line 3).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

A script to check,
If pods have caused a wreck,
Talos's plight,
Network not right,
Ignored, to keep CI in check.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request introduces a change to the ci-check-crash.sh script to ignore cni-server restarts caused by join network check failures on Talos nodes. This is a targeted fix that addresses a specific issue in the CI environment. The changes involve checking restart counts for both init containers and regular containers, and adding a condition to ignore cni-server restarts if the logs indicate a "network not ready" error. Overall, the changes seem reasonable, but there are a few areas that could be improved for clarity and robustness.

Summary of Findings

• Container type iteration: The script iterates through initContainer and container types. Consider adding a comment explaining why this is necessary and what scenarios it addresses.
• Talos provider check: The script checks for the Talos provider and ignores cni-server restarts with a specific log message. Ensure this logic is robust and doesn't inadvertently ignore other legitimate cni-server issues on Talos.
• Log message matching: The script uses grep -q to check for "network not ready" in the logs. This might be too specific and could miss variations of the message. Consider making the pattern more flexible or adding additional checks.

Merge Readiness

The changes address a specific CI issue and seem generally well-implemented. However, I recommend addressing the comments regarding container type iteration, Talos provider check robustness, and log message matching before merging. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging.

[coveralls]

Pull Request Test Coverage Report for Build 14635331918

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.004%) to 21.724%

---

Totals
Change from base Build 14634730232:	0.004%
Covered Lines:	10251
Relevant Lines:	47187

---

💛 - Coveralls