Support arm64 for Hugging Face trainer #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tariq-hasan <[email protected]>
Signed-off-by: tariq-hasan <[email protected]>
Signed-off-by: tariq-hasan <[email protected]>
Signed-off-by: tariq-hasan <[email protected]>
tariq-hasan
force-pushed
the
support-arm64-for-huggingface-trainer
branch
from
55946f9 to
e7f4623
Compare
|
@tariq-hasan Great work! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tariq-hasan, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 8263475761Details
💛 - Coveralls |
|
Thanks for this. |
tedhtchang
pushed a commit
to tedhtchang/training-operator
that referenced
this pull request
Apr 5, 2024
* echoed disk usage before cleanup Signed-off-by: tariq-hasan <[email protected]> * pruned docker images Signed-off-by: tariq-hasan <[email protected]> * moved docker data directory Signed-off-by: tariq-hasan <[email protected]> * added arm64 in the list of platforms for trainer-huggingface Signed-off-by: tariq-hasan <[email protected]> --------- Signed-off-by: tariq-hasan <[email protected]>
deepanker13
pushed a commit
to deepanker13/deepanker-training-operator
that referenced
this pull request
Apr 8, 2024
* echoed disk usage before cleanup Signed-off-by: tariq-hasan <[email protected]> * pruned docker images Signed-off-by: tariq-hasan <[email protected]> * moved docker data directory Signed-off-by: tariq-hasan <[email protected]> * added arm64 in the list of platforms for trainer-huggingface Signed-off-by: tariq-hasan <[email protected]> --------- Signed-off-by: tariq-hasan <[email protected]> Signed-off-by: deepanker13 <[email protected]>
johnugeorge
pushed a commit
to johnugeorge/training-operator
that referenced
this pull request
Apr 28, 2024
* echoed disk usage before cleanup Signed-off-by: tariq-hasan <[email protected]> * pruned docker images Signed-off-by: tariq-hasan <[email protected]> * moved docker data directory Signed-off-by: tariq-hasan <[email protected]> * added arm64 in the list of platforms for trainer-huggingface Signed-off-by: tariq-hasan <[email protected]> --------- Signed-off-by: tariq-hasan <[email protected]>
johnugeorge
pushed a commit
to johnugeorge/training-operator
that referenced
this pull request
Apr 28, 2024
* echoed disk usage before cleanup Signed-off-by: tariq-hasan <[email protected]> * pruned docker images Signed-off-by: tariq-hasan <[email protected]> * moved docker data directory Signed-off-by: tariq-hasan <[email protected]> * added arm64 in the list of platforms for trainer-huggingface Signed-off-by: tariq-hasan <[email protected]> --------- Signed-off-by: tariq-hasan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Following suggestion from @tenzen-y I have implemented a fix in the CI workflow to add support for multi-platform linux/amd64 and linux/arm64 image building for the Hugging Face trainer.
The necessary code changes follow from kserve/kserve#3411.
In particular, docker images are pruned and the docker data directory is moved from the root volume to the /mnt volume.
The resulting reduction in disk space usage in the root volume helps the CI workflow to complete without errors.
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #1986
Checklist: