Skip to content

test(coscheduling): add uts for coscheduling plugin. #2582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test(coscheduling): add uts for coscheduling plugin. #2582

wants to merge 1 commit into from

Conversation

IRONICBo
Copy link
Contributor

@IRONICBo IRONICBo commented Apr 4, 2025 •
edited by tenzen-y
Loading

What this PR does / why we need it:

Other plugins in pkg/runtime/framework/plugins have corresponding UTs, but the scheduling plugin does not have a UT for itself. I want to add some UTs for it.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Part-of: #2582

Checklist:

  • Docs included if any changes are user facing

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IRONICBo
Copy link
Contributor Author

IRONICBo commented Apr 4, 2025

/rerun-all

@IRONICBo IRONICBo changed the title feat: add uts for coscheduling plugin. test(coscheduling): add uts for coscheduling plugin. Apr 4, 2025
@IRONICBo
Copy link
Contributor Author

IRONICBo commented Apr 4, 2025 •
edited
Loading

The PodGroupRuntimeClassHandler and PodGroupLimitRangeHandler UTs are a bit complex. I will update these later. I would be pleased if you had any suggestions.

cc @Electronic-Waste

@coveralls
Copy link

coveralls commented Apr 4, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 14687946875

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.1%) to 68.659%
Totals Coverage Status
Change from base Build 14681761318: 2.1%
Covered Lines: 1792
Relevant Lines: 2610
💛 - Coveralls

@IRONICBo IRONICBo force-pushed the feat/add-coscheduling-uts branch from 9b313ae to a0065e4 Compare April 4, 2025 04:41
@Electronic-Waste
Copy link
Member

The PodGroupRuntimeClassHandler and PodGroupLimitRangeHandler UTs are a bit complex. I will update these later. I would be pleased if you had any suggestions.

/cc @kubeflow/wg-training-leads @astefanutti

@google-oss-prow google-oss-prow bot requested review from astefanutti and a team April 9, 2025 08:31
@tenzen-y tenzen-y mentioned this pull request Apr 15, 2025
Open
6 tasks
tenzen-y
tenzen-y reviewed Apr 15, 2025
View reviewed changes
@tenzen-y
Copy link
Member

@IRONICBo Do you have any updates?

@IRONICBo IRONICBo force-pushed the feat/add-coscheduling-uts branch from a0065e4 to ff1239a Compare April 26, 2025 04:55
@google-oss-prow google-oss-prow bot added size/XL and removed size/L labels Apr 26, 2025
@IRONICBo
Copy link
Contributor Author

@IRONICBo Do you have any updates?

Sorry I've been preparing for final exams this week and have now updated, please take a look about it. @tenzen-y @Electronic-Waste

@IRONICBo IRONICBo requested a review from tenzen-y April 26, 2025 12:24
@IRONICBo IRONICBo force-pushed the feat/add-coscheduling-uts branch from ff1239a to 326ff75 Compare April 27, 2025 03:29
@google-oss-prow google-oss-prow bot added size/L and removed size/XL labels Apr 27, 2025
@IRONICBo
Copy link
Contributor Author

/rerun-all

@IRONICBo
Copy link
Contributor Author

IRONICBo commented May 3, 2025

@Electronic-Waste @tenzen-y Hi, do you have time to review my PR?

@IRONICBo
Copy link
Contributor Author

IRONICBo commented May 3, 2025 •
edited
Loading

Besides, the /rerun-all command doesn't seem to work.

@IRONICBo
Copy link
Contributor Author

IRONICBo commented May 4, 2025

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Electronic-Waste Electronic-Waste Awaiting requested review from Electronic-Waste

@jinchihe jinchihe Awaiting requested review from jinchihe

@astefanutti astefanutti Awaiting requested review from astefanutti

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

Assignees
No one assigned
Labels
ok-to-test size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IRONICBo @coveralls @Electronic-Waste @tenzen-y