Skip to content

Fix llm hp optimization error #2576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sdk/python/kubeflow/storage_initializer/hugging_face.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,9 @@ def download_model_and_tokenizer(self):
trust_remote_code=True,
)
transformers.AutoTokenizer.from_pretrained(
self.model, cache_dir=VOLUME_PATH_MODEL
self.model,
token=self.config.access_token,
cache_dir=VOLUME_PATH_MODEL,
)


Expand Down
8 changes: 4 additions & 4 deletions sdk/python/kubeflow/storage_initializer/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
peft==0.3.0
datasets==2.21.0
transformers==4.38.0
boto3==1.33.9
peft==0.15.1
datasets==3.5.0
transformers==4.50.2
boto3==1.37.22
11 changes: 11 additions & 0 deletions sdk/python/kubeflow/trainer/hf_llm_training.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
AutoModelForImageClassification,
AutoTokenizer,
DataCollatorForLanguageModeling,
DataCollatorWithPadding,
Trainer,
TrainingArguments,
)
Expand Down Expand Up @@ -59,6 +60,9 @@ def setup_model_and_tokenizer(model_uri, transformer_type, model_dir, num_labels
for param in model.parameters():
param.requires_grad = False

if not tokenizer.pad_token:
tokenizer.pad_token = tokenizer.eos_token

return model, tokenizer


Expand Down Expand Up @@ -148,6 +152,13 @@ def train_model(model, transformer_type, train_data, eval_data, tokenizer, train
pad_to_multiple_of=8,
mlm=False,
)
else:
logger.info("Add general data collator with padding")
logger.info("-" * 40)
trainer.data_collator = DataCollatorWithPadding(
tokenizer,
pad_to_multiple_of=8,
)

# Train the model.
trainer.train()
Expand Down
9 changes: 5 additions & 4 deletions sdk/python/kubeflow/trainer/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
peft==0.3.0
datasets==2.21.0
transformers==4.38.0
accelerate==0.28.0
peft==0.15.1
datasets==3.5.0
transformers==4.50.2
accelerate==1.5.2
tensorboard==2.19.0
2 changes: 1 addition & 1 deletion sdk/python/kubeflow/training/api/training_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ def train(
VOLUME_PATH_DATASET,
"--lora_config",
json.dumps(
trainer_parameters.lora_config.__dict__, cls=utils.SetEncoder
trainer_parameters.lora_config.to_dict(), cls=utils.SetEncoder
),
"--training_parameters",
json.dumps(trainer_parameters.training_parameters.to_dict()),
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,6 @@
tests_require=TESTS_REQUIRES,
extras_require={
"test": TESTS_REQUIRES,
"huggingface": ["transformers==4.38.0", "peft==0.3.0"],
"huggingface": ["transformers==4.50.2", "peft==0.15.1"],
},
)
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def test_sdk_e2e_create_from_train_api(job_namespace="default"):
training_parameters=transformers.TrainingArguments(
output_dir="test_trainer",
save_strategy="no",
evaluation_strategy="no",
eval_strategy="no",
do_eval=False,
disable_tqdm=True,
log_level="info",
Expand Down
Loading