Skip to content

Add a workflow for publishing Helm charts #2571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

izuku-sds
Copy link

@izuku-sds izuku-sds commented Mar 28, 2025

What this PR does / why we need it:

  • workflow for publishing Helm charts to GHCR
  • More robust tests are needed for Helm charts
  • Use gh page for hosting Helm charts

Note: Good to merge after #2435 . Till then a sample helm chart is added for testing.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #2488

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: izuku-sds <[email protected]>
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andreyvelich for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@izuku-sds
Copy link
Author

izuku-sds commented Mar 28, 2025

Please review and suggest changes.
/cc @andreyvelich @varodrig @ChenYi015

Signed-off-by: izuku-sds <[email protected]>
@izuku-sds
Copy link
Author

Package and push helm chart Error should be able to pass when github.actor = kubeflow currently it is taking my username izuku-sds

@IRONICBo
Copy link
Contributor

/ok-to-test
/rerun-all

@coveralls
Copy link

Pull Request Test Coverage Report for Build 14140929950

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 18 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.08%) to 66.475%

Files with Coverage Reduction New Missed Lines %
pkg/runtime/framework/plugins/mpi/mpi.go 18 88.94%
Totals Coverage Status
Change from base Build 14113635407: 0.08%
Covered Lines: 1735
Relevant Lines: 2610

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a workflow for publishing Helm charts
3 participants