Skip to content

[feature] pull images in manifest from ghcr #2529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mahdikhashan
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
part of #2455

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: mahdikhashan <[email protected]>
@tenzen-y
Copy link
Member

tenzen-y commented Mar 16, 2025

@mahdikhashan I guess this PR requires rebase

@tenzen-y
Copy link
Member

It seems Docker Login is not correct.
https://github.com/kubeflow/trainer/actions/runs/13884934312/job/38848363309

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mahdikhashan mahdikhashan force-pushed the move-images-manifest-ghcr branch from c101731 to 78526d1 Compare March 16, 2025 15:48
@mahdikhashan
Copy link
Member Author

It seems Docker Login is not correct. https://github.com/kubeflow/trainer/actions/runs/13884934312/job/38848363309

fixed here: https://github.com/kubeflow/trainer/pull/2530/files

@tenzen-y
Copy link
Member

@tenzen-y
Copy link
Member

After https://github.com/kubeflow/trainer/actions/runs/13884934312/job/38848363434 complete, I will rerun E2E

Done

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming E2E succeed

/lgtm
/approve

Thnak you

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 7dcd9b3 into kubeflow:master Mar 16, 2025
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants