-
Notifications
You must be signed in to change notification settings - Fork 786
[feature] pull images in manifest from ghcr #2529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] pull images in manifest from ghcr #2529
Conversation
Signed-off-by: mahdikhashan <[email protected]>
@mahdikhashan I guess this PR requires rebase |
It seems Docker Login is not correct. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
c101731
to
78526d1
Compare
fixed here: https://github.com/kubeflow/trainer/pull/2530/files |
After https://github.com/kubeflow/trainer/actions/runs/13884934312/job/38848363434 complete, I will rerun E2E |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming E2E succeed
/lgtm
/approve
Thnak you
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):part of #2455
Checklist: