Skip to content

Add unmaintained notice to contrib components #2313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

annajung
Copy link
Member

@annajung annajung commented Nov 17, 2022

Signed-off-by: Anna Jung (VMware) [email protected]

Which issue is resolved by this Pull Request:
Part of #2311

Description of your changes:

  • Add README to the following components to mark the directory as unmaintained and out of date
    • /contrib/application
    • /contrib/basic-auth
    • /contrib/experimental
    • /contrib/gatekeeper
    • /contrib/modeldb
    • /contrib/spartakus

cc @kimwnasptd @kubeflow/wg-manifests-leads

@annajung
Copy link
Member Author

The OWNERS file is not available, therefore, am not sure who originally created the component.
Based on the design doc and commit history, I'm tagging @yanniszark to ensure the component OWNER(s) are aware of the out-of-date label put on the component.

cc @kimwnasptd

@annajung
Copy link
Member Author

To remove the unmaintained label, check out the `missing requirements #2311 and leave a comment on the issue to indicate that you'll take action to provide the missing requirements and are willing to keep the component up to date. Thank you!

@kimwnasptd
Copy link
Member

The message looks good. @annajung I'm guessing we are going to use the same for the other READMEs as well right? I.e. https://github.com/kubeflow/manifests/tree/master/contrib/feast

@annajung
Copy link
Member Author

@kimwnasptd Yes, that's the plan. I'm creating a separate PR for each component to ensure that the relevant components' owners are tagged.

Anna Jung (VMware) added 4 commits November 21, 2022 14:35
@annajung annajung force-pushed the contrib-application-deprecation branch from 3c54a7e to 62dd45c Compare November 21, 2022 19:42
@annajung
Copy link
Member Author

@kimwnasptd Update: The components that did not have the OWNERS file are merged into this PR now. Rest that requires tagging owners for awareness will be a separate PR

@annajung
Copy link
Member Author

/retitle Add unmaintained notice to contrib components

@annajung annajung changed the title Add unmaintained notice to contrib application Add unmaintained notice to contrib components Nov 21, 2022
@kimwnasptd
Copy link
Member

I like the approach of first tackling the components without OWNERs. Then we can move on with the unmaintained ones.

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: annajung, kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit acbb6bf into kubeflow:master Nov 22, 2022
kevin85421 pushed a commit to juliusvonkohout/manifests that referenced this pull request Feb 28, 2023
* Add unmaintained notice to contrib basic-auth

Signed-off-by: Anna Jung (VMware) <[email protected]>

* Add unmaintained notice to contrib experimental

Signed-off-by: Anna Jung (VMware) <[email protected]>

* Add unmaintained notice to contrib application

Signed-off-by: Anna Jung (VMware) <[email protected]>

* Add unmaintained notice to contrib spartakus

Signed-off-by: Anna Jung (VMware) <[email protected]>

* Add unmaintained notice to contrib modeldb

Signed-off-by: Anna Jung (VMware) <[email protected]>

* Add unmaintained notice to contrib gatekeeper

Signed-off-by: Anna Jung (VMware) <[email protected]>

Signed-off-by: Anna Jung (VMware) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants