knative-serving: Workaround Istio race wrt Gateway creation #2092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deploying knative-serving there a race due to an Istio issue that ends up having cluster-local-gateway misconfigured because of conflicting ports. In a nutshell Istio creates listeners based on Gateway ports and the corresponding Services (if any) and in our case we have two Services (cluster-local-gateway, knative-local-gateway) with port 80 and different targetPort (8080, 8081). In normal operation the pod gets the following listeners: ADDRESS PORT MATCH DESTINATION 0.0.0.0 8080 ALL Route: http.80 0.0.0.0 8081 ALL Route: http.8081 We have seen on fresh deployment to end up with only 8081:8081 and istio complaining with: Error adding/updating listener(s) 0.0.0.0_8081: duplicate listener 0.0.0.0_8081 found To fix that add a label in knative-local-gateway service so that it gets ignored by istio when translating gateway ports. Signed-off-by: Kimonas Sotirchos <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks @kimwnasptd ! /lgtm |
kimwnasptd
added a commit
to arrikto/kubeflow-manifests
that referenced
this pull request
Dec 22, 2021
…#2092) When deploying knative-serving there a race due to an Istio issue that ends up having cluster-local-gateway misconfigured because of conflicting ports. In a nutshell Istio creates listeners based on Gateway ports and the corresponding Services (if any) and in our case we have two Services (cluster-local-gateway, knative-local-gateway) with port 80 and different targetPort (8080, 8081). In normal operation the pod gets the following listeners: ADDRESS PORT MATCH DESTINATION 0.0.0.0 8080 ALL Route: http.80 0.0.0.0 8081 ALL Route: http.8081 We have seen on fresh deployment to end up with only 8081:8081 and istio complaining with: Error adding/updating listener(s) 0.0.0.0_8081: duplicate listener 0.0.0.0_8081 found To fix that add a label in knative-local-gateway service so that it gets ignored by istio when translating gateway ports. Signed-off-by: Kimonas Sotirchos <[email protected]>
google-oss-prow bot
pushed a commit
that referenced
this pull request
Dec 22, 2021
…2094) When deploying knative-serving there a race due to an Istio issue that ends up having cluster-local-gateway misconfigured because of conflicting ports. In a nutshell Istio creates listeners based on Gateway ports and the corresponding Services (if any) and in our case we have two Services (cluster-local-gateway, knative-local-gateway) with port 80 and different targetPort (8080, 8081). In normal operation the pod gets the following listeners: ADDRESS PORT MATCH DESTINATION 0.0.0.0 8080 ALL Route: http.80 0.0.0.0 8081 ALL Route: http.8081 We have seen on fresh deployment to end up with only 8081:8081 and istio complaining with: Error adding/updating listener(s) 0.0.0.0_8081: duplicate listener 0.0.0.0_8081 found To fix that add a label in knative-local-gateway service so that it gets ignored by istio when translating gateway ports. Signed-off-by: Kimonas Sotirchos <[email protected]>
yhwang
pushed a commit
to yhwang/manifests
that referenced
this pull request
Jan 4, 2022
…#2092) When deploying knative-serving there a race due to an Istio issue that ends up having cluster-local-gateway misconfigured because of conflicting ports. In a nutshell Istio creates listeners based on Gateway ports and the corresponding Services (if any) and in our case we have two Services (cluster-local-gateway, knative-local-gateway) with port 80 and different targetPort (8080, 8081). In normal operation the pod gets the following listeners: ADDRESS PORT MATCH DESTINATION 0.0.0.0 8080 ALL Route: http.80 0.0.0.0 8081 ALL Route: http.8081 We have seen on fresh deployment to end up with only 8081:8081 and istio complaining with: Error adding/updating listener(s) 0.0.0.0_8081: duplicate listener 0.0.0.0_8081 found To fix that add a label in knative-local-gateway service so that it gets ignored by istio when translating gateway ports. Signed-off-by: Kimonas Sotirchos <[email protected]>
Tomcli
pushed a commit
to IBM/manifests
that referenced
this pull request
Jan 4, 2022
…#2092) When deploying knative-serving there a race due to an Istio issue that ends up having cluster-local-gateway misconfigured because of conflicting ports. In a nutshell Istio creates listeners based on Gateway ports and the corresponding Services (if any) and in our case we have two Services (cluster-local-gateway, knative-local-gateway) with port 80 and different targetPort (8080, 8081). In normal operation the pod gets the following listeners: ADDRESS PORT MATCH DESTINATION 0.0.0.0 8080 ALL Route: http.80 0.0.0.0 8081 ALL Route: http.8081 We have seen on fresh deployment to end up with only 8081:8081 and istio complaining with: Error adding/updating listener(s) 0.0.0.0_8081: duplicate listener 0.0.0.0_8081 found To fix that add a label in knative-local-gateway service so that it gets ignored by istio when translating gateway ports. Signed-off-by: Kimonas Sotirchos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves #2082
Description of your changes:
When deploying knative-serving there a race due to an Istio issue that ends up having cluster-local-gateway misconfigured because of conflicting ports. In a nutshell Istio creates listeners based on Gateway ports and the corresponding Services (if any) and in our case we have two Services (cluster-local-gateway, knative-local-gateway) with port 80 and different targetPort (8080, 8081). In normal operation the pod gets the following listeners:
We have seen on fresh deployment to end up with only 8081:8081 and istio complaining with:
To fix that add a label in knative-local-gateway service so that it gets ignored by istio when translating gateway ports.
/cc @elikatsis