Skip to content

fix issue 209 #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2022
Merged

fix issue 209 #227

merged 2 commits into from
Oct 26, 2022

Conversation

yanggangtony
Copy link
Contributor

@yanggangtony yanggangtony commented Oct 20, 2022

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #209

Special notes for your reviewer:

@nothingcompare2u
Copy link
Contributor

/lgtm

@ErikJiang
Copy link
Member

/approve

@kubean-pr-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ErikJiang, yanggangtony

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubean-pr-robot kubean-pr-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2022
@ErikJiang ErikJiang merged commit 13e068d into kubean-io:main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

documentation bug issue: doc/offline.zh.md should add precondition
3 participants