Skip to content

Add recursive user manifests #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 21, 2024
Merged

Conversation

markusheinemann
Copy link
Contributor

@markusheinemann markusheinemann commented Apr 8, 2024

see #1313

How to Test

  1. Create the following files inside of extra-manifests:

kustomization.yaml.tpl

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

resources:
  - subfolder

subfolder/kustomization.yaml.tpl

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

resources:
  - namespace.yaml

subfolder/namespace.yaml.tpl

apiVersion: v1
kind: Namespace
metadata:
  name: mynamespace
  1. Create a cluster using terrafom apply

  2. Check if the resource has been applied: kubectl get ns

--> It work's on my machine 🤣

Copy link
Collaborator

@mysticaltech mysticaltech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markusheinemann Thanks for this. Looking good. Please if you could tweak the docs for this, especially in the examples section in the readme and other relevant places (if this is mentioned there, like kube.tf), it would be great.

@markusheinemann markusheinemann force-pushed the master branch 2 times, most recently from 10082ec to 96b29cc Compare April 9, 2024 07:17
@markusheinemann
Copy link
Contributor Author

@markusheinemann Thanks for this. Looking good. Please if you could tweak the docs for this, especially in the examples section in the readme and other relevant places (if this is mentioned there, like kube.tf), it would be great.

I have updated the related docs and updated the examples as well. I am happy about your feedback.

@markusheinemann
Copy link
Contributor Author

markusheinemann commented Apr 11, 2024

Actual the provided solution will not work due to hashicorp/terraform#16330. I'm currently looking for a workaround

Copy link
Collaborator

@mysticaltech mysticaltech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @markusheinemann! Please let me know when it's working.

@mysticaltech
Copy link
Collaborator

@markusheinemann What about now?

@markusheinemann
Copy link
Contributor Author

lgtm. I think the PR can be merged in my eyes. Can you please rerun the workflow?

PS. Sorry for closing the PR due to an oversight

@mysticaltech
Copy link
Collaborator

Thanks again for this @markusheinemann, awesome!

@mysticaltech mysticaltech merged commit a802c07 into kube-hetzner:master May 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants