Skip to content

Global configuration is not considered in namespaced PFConfigs in a context of a namespaced Pipeline #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keskad opened this issue Apr 29, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@keskad
Copy link
Contributor

keskad commented Apr 29, 2024

Example:

logs-enabled: "false"   # this does not work
jxscm.git-kind: gitlab

Expectations:

Global configuration keys would be overwritten in given namespace, where global key is defined in PFConfig - e.g. logs-enabled

@keskad keskad added the bug Something isn't working label Apr 29, 2024
keskad added a commit that referenced this issue May 22, 2024
@keskad
Copy link
Contributor Author

keskad commented May 22, 2024

I created a simple workaround by adding support for specyfing pipelines-feedback.json global controller configuration to the Helm Chart. Thanks to this global configuration can be changed at all at this moment, but this does not fix a bug, where non-component configuration is not loaded from PFConfigs.

@keskad keskad self-assigned this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant