Skip to content
This repository was archived by the owner on Jan 31, 2025. It is now read-only.

add switch for zeroExitCode even for failing tests #64

Merged
merged 2 commits into from
Aug 9, 2019

Conversation

zzhengjian
Copy link

user can just add below setting to profile:base "zeroExitCode": true, to enable always zeroExitCode for nemo.

@zzhengjian
Copy link
Author

Hi, @grawk Can you take a review for this PR?

@grawk
Copy link
Member

grawk commented May 6, 2019

Hello @zzhengjian .. Sorry I was on vacation. Can you please

  • consider whether we should check the actual value of the config if present (i.e. what are valid values and what is the behavior)
  • add documentation for this flag to the README based on the above

@zzhengjian
Copy link
Author

Hi, @grawk
I've add the doc to README based on your comments, can you have a look and see if there's anything missing?

@zzhengjian
Copy link
Author

Hi, @grawk
Can you please have a review and merge the PR if possible?

@grawk grawk merged commit 0f8f527 into krakenjs:master Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants