koordlet: support extension controllers #2459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaloulcy
force-pushed
the
support_extension_controller
branch
from
9129c9c to
c566094
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2459 +/- ##
==========================================
- Coverage 65.94% 65.93% -0.01%
==========================================
Files 477 477
Lines 56180 56193 +13
==========================================
+ Hits 37048 37053 +5
- Misses 16448 16455 +7
- Partials 2684 2685 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shaloulcy
force-pushed
the
support_extension_controller
branch
from
c566094 to
fa50066
Compare
saintube
reviewed
May 26, 2025
shaloulcy
force-pushed
the
support_extension_controller
branch
from
fa50066 to
a5f5224
Compare
Signed-off-by: shaloulcy <[email protected]>
shaloulcy
force-pushed
the
support_extension_controller
branch
from
a5f5224 to
b4bfde9
Compare
hormes
approved these changes
May 27, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, saintube The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
koordlet: support extension controllers
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test