-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move over the helm chart for the ui from the operator repo #55
chore: move over the helm chart for the ui from the operator repo #55
Conversation
Thanks for making a pull request! 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't we need a copy of the helm chart here retained till the new operator is in place? Otherwise the current helm based operator is not valid. So we can only remove the GitHub action part alone. Also from operator perspective, in read me, the helm chart reference can possible be removed.
Also the prepare for release section from mahespur might need to be removed |
done |
aren't the release tar files enough? |
The operator Dockerfile uses the helm chart from its context (the operator repo). |
I commented that out https://github.com/konveyor/move2kube-operator/pull/55/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557R6 |
Yes, that line is required. Without it, the operator does nothing. |
yes, but isn't it broken anyway? |
We have not tested it extensively with the new UI. But technically, it should be working, since the operator does nothing but the equivalent of a helm install |
chore: retain the helm chart for current operator to continue functioning Signed-off-by: Harikrishnan Balagopal <[email protected]>
ee90efe
to
9563bd1
Compare
Signed-off-by: Harikrishnan Balagopal [email protected]