Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move over the helm chart for the ui from the operator repo #55

Merged

Conversation

HarikrishnanBalagopal
Copy link
Contributor

Signed-off-by: Harikrishnan Balagopal [email protected]

@github-actions
Copy link

github-actions bot commented Jan 3, 2022

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the chore label Jan 3, 2022
Copy link
Member

@ashokponkumar ashokponkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't we need a copy of the helm chart here retained till the new operator is in place? Otherwise the current helm based operator is not valid. So we can only remove the GitHub action part alone. Also from operator perspective, in read me, the helm chart reference can possible be removed.

@ashokponkumar
Copy link
Member

Also the prepare for release section from mahespur might need to be removed

@HarikrishnanBalagopal
Copy link
Contributor Author

Also the prepare for release section from mahespur might need to be removed

done

@HarikrishnanBalagopal
Copy link
Contributor Author

Won't we need a copy of the helm chart here retained till the new operator is in place? Otherwise the current helm based operator is not valid. So we can only remove the GitHub action part alone. Also from operator perspective, in read me, the helm chart reference can possible be removed.

aren't the release tar files enough?

@ashokponkumar
Copy link
Member

The operator Dockerfile uses the helm chart from its context (the operator repo).

@HarikrishnanBalagopal
Copy link
Contributor Author

The operator Dockerfile uses the helm chart from its context (the operator repo).

I commented that out https://github.com/konveyor/move2kube-operator/pull/55/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557R6

@ashokponkumar
Copy link
Member

The operator Dockerfile uses the helm chart from its context (the operator repo).

I commented that out https://github.com/konveyor/move2kube-operator/pull/55/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557R6

Yes, that line is required. Without it, the operator does nothing.

@HarikrishnanBalagopal
Copy link
Contributor Author

The operator Dockerfile uses the helm chart from its context (the operator repo).

I commented that out https://github.com/konveyor/move2kube-operator/pull/55/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557R6

Yes, that line is required. Without it, the operator does nothing.

yes, but isn't it broken anyway?

@ashokponkumar
Copy link
Member

We have not tested it extensively with the new UI. But technically, it should be working, since the operator does nothing but the equivalent of a helm install

chore: retain the helm chart for current operator to continue functioning

Signed-off-by: Harikrishnan Balagopal <[email protected]>
@ashokponkumar ashokponkumar merged commit 027c483 into konveyor:main Jan 4, 2022
@HarikrishnanBalagopal HarikrishnanBalagopal deleted the chore/removehelm branch January 4, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants