Skip to content

🌱 add another effort level before max #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2025
Merged

🌱 add another effort level before max #346

merged 1 commit into from
Feb 5, 2025

Conversation

djzager
Copy link
Member

@djzager djzager commented Feb 4, 2025

No description provided.

@djzager djzager requested a review from a team as a code owner February 4, 2025 17:02
fabianvf
fabianvf previously approved these changes Feb 4, 2025
View reviewed changes
sjd78
sjd78 previously approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only comment is an edge case for config values. Best to put the check in, but can get by without.

@djzager djzager dismissed stale reviews from sjd78 and fabianvf via 2bc5d9a February 4, 2025 18:50
@djzager djzager requested a review from sjd78 February 4, 2025 18:50
sjd78
sjd78 approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djzager djzager merged commit bb5e544 into konveyor:main Feb 5, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjd78 sjd78 sjd78 approved these changes

@fabianvf fabianvf fabianvf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djzager @fabianvf @sjd78