Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Implement functional CodeActionProvider with Continue #468

Merged
merged 3 commits into from
Apr 9, 2025

Conversation

djzager
Copy link
Member

@djzager djzager commented Apr 3, 2025

This makes it so we have a functional code action provider that allows us to either Ask Kai or Ask Continue with Konveyor Context.

Fixes #452

This makes it so we have a functional code action provider that allows us to
either Ask Kai or Ask Continue with Konveyor Context.

Signed-off-by: David Zager <[email protected]>
@djzager djzager requested a review from a team as a code owner April 3, 2025 17:29
Signed-off-by: David Zager <[email protected]>
@djzager djzager requested a review from rszwajko April 8, 2025 01:14
ibolton336
ibolton336 previously approved these changes Apr 9, 2025
Copy link
Member

@ibolton336 ibolton336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit pick on dependency.

Signed-off-by: David Zager <[email protected]>
Copy link
Member

@ibolton336 ibolton336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See question posted inline. Not a blocker but just would like to make sure we have a potential UX change / issue around this logged to circle back to.

Copy link
Member

@ibolton336 ibolton336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@djzager djzager merged commit 5f0ea7d into konveyor:main Apr 9, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate integration(s) into Continue.dev
4 participants