✨ Add go grep package to replace OS-specific grep commands for builtin provider #737
+97
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kthatipally
changed the title
Signed-off-by: kthatipally <[email protected]>
kthatipally
force-pushed
the
kthatipally/add-grep-regex2-go-package
branch
from
5b73431 to
e002d57
Compare
kthatipally
changed the title
jmle
added
the
do-not-merge/work-in-progress
| } | ||
|
|
||
| if f.Mode().IsRegular() { | ||
| eg.Go(func() error { |
There was a problem hiding this comment.
We might want to put a limit on this across the engine this could spawn a bunch of go routines I think just setting the limit on the errorgroup.Group should be enough
|
We need to test this with this rule id to make sure that it covers the lookahead and lookbehind |
Signed-off-by: kthatipally <[email protected]>
Signed-off-by: kthatipally <[email protected]>
Signed-off-by: kthatipally <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request introduces a cross-platform supported grep package to replace OS-specific grep commands.
This the regex2 package to scan files and search for patterns, making the codebase more portable and easier to maintain: https://github.com/dlclark/regexp2 (supports lookahead)
provider/internal/builtin/service_client.go: Replaced OS-specific grep command with a cross-platform solution using regexp2 and file scanning.
go.mod and go.sum: Added regexp2 dependency.
WIP: Testing, resolve merge-conflicts